Skip to content

Custom entity edges #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Custom entity edges #257

wants to merge 11 commits into from

Conversation

paul-paliychuk
Copy link
Contributor

@paul-paliychuk paul-paliychuk commented May 27, 2025

Important

Add support for custom entity edges in Zep Cloud SDK, including new edge types and source-target relationships.

  • Behavior:
    • set_entity_types in graph.py now supports edges parameter for defining edge types.
    • AsyncGraphClient and GraphClient updated to handle edge types.
  • Models:
    • New EdgeType and EntityEdgeSourceTarget classes added to represent edges and their source-target relationships.
    • EntityTypeResponse updated to include edge_types.
  • Misc:
    • Version updated to 2.13.0 in pyproject.toml and client_wrapper.py.
    • Minor whitespace fix in memory.py.

This description was created by Ellipsis for 6a5be5e. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 3e75648 in 1 minute and 43 seconds. Click for details.
  • Reviewed 277 lines of code in 10 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/zep_cloud/graph/client.py:87
  • Draft comment:
    The update in set_entity_types_internal includes the new 'edge_types' parameter in the JSON payload. Ensure that backend API and client tests cover both the new edge_types and existing entity_types for backward compatibility.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to ensure that tests cover both new and existing parameters for backward compatibility. This falls under the rule of not asking the author to ensure things are tested, which is not allowed.
2. src/zep_cloud/types/edge_type.py:11
  • Draft comment:
    The EdgeType model is implemented consistently with other types; consider adding inline comments/examples on how to use the 'source_targets' field if documentation is lacking.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% Since this is an auto-generated file, any manual comments would be overwritten on the next generation. Documentation should be added to the API definition source instead. Additionally, the comment is asking for optional documentation rather than pointing out a clear issue that needs fixing. Perhaps documentation is critically important for this API type and the suggestion could be valuable if redirected to the API definition source. Even if documentation is important, suggesting changes to an auto-generated file is not the right approach. Such suggestions should be made on the API definition source files instead. Delete the comment because it suggests modifying an auto-generated file and doesn't point out a clear issue that requires fixing.
3. src/zep_cloud/types/entity_type_response.py:12
  • Draft comment:
    The addition of the optional 'edge_types' field in EntityTypeResponse is clear. Confirm that the API documents the expected structure for 'edge_types' for user clarity.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is asking the PR author to confirm something about the API documentation, which violates the rule against asking for confirmation or ensuring behavior. It does not provide a specific suggestion or point out a clear issue.

Workflow ID: wflow_yMof4QzTgoEYsveC

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed 6a5be5e in 49 seconds. Click for details.
  • Reviewed 76 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/zep_cloud/external_clients/ontology.py:7
  • Draft comment:
    Removed unused import of EntityEdgeSourceTarget and EntityType. Confirm that these are not needed elsewhere.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to confirm that the removed imports are not needed elsewhere. This falls under the rule of not asking the author to confirm their intention or to double-check things. Therefore, this comment should not be approved.
2. src/zep_cloud/external_clients/ontology.py:147
  • Draft comment:
    Function 'convert_edge_schema_to_model' has been removed. Ensure any references to this conversion are updated and backward compatibility is maintained.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_OKwcJJHF0hdAYPq9

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant