Skip to content

Add episodes to entity node #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 48 commits into from
Apr 21, 2025
Merged

Add episodes to entity node #249

merged 48 commits into from
Apr 21, 2025

Conversation

paul-paliychuk
Copy link
Contributor

@paul-paliychuk paul-paliychuk commented Apr 21, 2025

Important

Add episodes field to EntityNode and update set_entity_types_internal to accept optional entity types, with version bump to 2.10.2.

  • EntityNode:
    • Add episodes field to EntityNode in entity_node.py to store list of episode UUIDs.
  • Functionality:
    • Update set_entity_types_internal in client.py to accept typing.Optional[typing.Sequence[EntityType]].
    • Update set_entity_types_internal in client.py to handle None for entity_types.
  • Versioning:
    • Increment version to 2.10.2 in pyproject.toml and client_wrapper.py.

This description was created by Ellipsis for f4c930b. You can customize this summary. It will automatically update as commits are pushed.

@paul-paliychuk paul-paliychuk merged commit ba29c46 into main Apr 21, 2025
4 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to f4c930b in 1 minute and 39 seconds. Click for details.
  • Reviewed 166 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/zep_cloud/types/entity_node.py:13
  • Draft comment:
    Consider revising docstring text to 'Dependent on node labels.' to 'Its interpretation depends on the node labels.' for clarity.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. src/zep_cloud/types/entity_node.py:16
  • Draft comment:
    The EntityNode model is clear and properly documented. One minor suggestion: consider using a datetime type (e.g. dt.datetime) for the 'created_at' field instead of str, if stricter type validation and automatic serialization is desired. If the API is expected to return a formatted string, then this is acceptable.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
3. src/zep_cloud/graph/client.py:144
  • Draft comment:
    In the docstring for the 'add' function, the sentence 'Note: each subscription tier has different limits on the amount of data that can be added to the graph please refer to the pricing page for more information.' would be clearer if it were broken up with proper punctuation (e.g., '... graph. Please refer to the pricing page for more information.'). This is a trivial typographical/style improvement.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_cv2TiIFScgKXS9do

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant