-
Notifications
You must be signed in to change notification settings - Fork 19
Add episodes to entity node #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pyproject.toml # reference.md # src/zep_cloud/core/client_wrapper.py # src/zep_cloud/graph/episode/client.py # src/zep_cloud/user/client.py
# Conflicts: # pyproject.toml # src/zep_cloud/core/client_wrapper.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed everything up to f4c930b in 1 minute and 39 seconds. Click for details.
- Reviewed
166
lines of code in5
files - Skipped
0
files when reviewing. - Skipped posting
3
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/zep_cloud/types/entity_node.py:13
- Draft comment:
Consider revising docstring text to 'Dependent on node labels.' to 'Its interpretation depends on the node labels.' for clarity. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. src/zep_cloud/types/entity_node.py:16
- Draft comment:
The EntityNode model is clear and properly documented. One minor suggestion: consider using a datetime type (e.g. dt.datetime) for the 'created_at' field instead of str, if stricter type validation and automatic serialization is desired. If the API is expected to return a formatted string, then this is acceptable. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
3. src/zep_cloud/graph/client.py:144
- Draft comment:
In the docstring for the 'add' function, the sentence 'Note: each subscription tier has different limits on the amount of data that can be added to the graph please refer to the pricing page for more information.' would be clearer if it were broken up with proper punctuation (e.g., '... graph. Please refer to the pricing page for more information.'). This is a trivial typographical/style improvement. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_cv2TiIFScgKXS9do
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add
episodes
field toEntityNode
and updateset_entity_types_internal
to accept optional entity types, with version bump to 2.10.2.episodes
field toEntityNode
inentity_node.py
to store list of episode UUIDs.set_entity_types_internal
inclient.py
to accepttyping.Optional[typing.Sequence[EntityType]]
.set_entity_types_internal
inclient.py
to handleNone
forentity_types
.pyproject.toml
andclient_wrapper.py
.This description was created by
for f4c930b. You can customize this summary. It will automatically update as commits are pushed.