Expose episode source argument when adding data #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pyproject.toml # reference.md # src/zep_cloud/core/client_wrapper.py # src/zep_cloud/graph/episode/client.py # src/zep_cloud/user/client.py
# Conflicts: # pyproject.toml # src/zep_cloud/core/client_wrapper.py
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 145126c in 2 minutes and 26 seconds
More details
- Looked at
192lines of code in5files - Skipped
0files when reviewing. - Skipped posting
5drafted comments based on config settings.
1. src/zep_cloud/core/client_wrapper.py:17
- Draft comment:
SDK version updated to 2.10.1. Ensure all clients and documentation are in sync with this version change. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
This comment is asking the PR author to ensure that all clients and documentation are in sync with the version change, which violates the rule against asking the author to ensure things are tested or verified. It also relates to a dependency change, which should not be commented on.
2. src/zep_cloud/graph/client.py:140
- Draft comment:
New 'add' method exposes 'source_description' and uses mandatory 'data' and 'type'. Verify these changes are covered in unit tests and that the documentation reflects the new parameters. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
The comment asks the PR author to verify that changes are covered in unit tests and that documentation reflects new parameters. This violates the rule against asking the author to ensure changes are tested or documented.
3. src/zep_cloud/types/episode.py:15
- Draft comment:
Ensure that the new field 'source_description' is documented in your API docs and its intended usage is clearly explained. - Reason this comment was not posted:
Comment was on unchanged code.
4. src/zep_cloud/graph/client.py:149
- Draft comment:
Improve docstring clarity by adding punctuation; for example, insert a semicolon after 'graph' in the note to separate ideas. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
5. src/zep_cloud/types/episode.py:11
- Draft comment:
The Episode model now correctly exposes 'source_description'; documentation and field aliasing appear consistent with the new API. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
Workflow ID: wflow_zGMBruxmIWwBHmy9
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Expose
source_descriptionargument inadd()method ofGraphClientandAsyncGraphClient, updatingEpisodemodel and bumping version to 2.10.1.source_descriptionargument inadd()method ofGraphClientandAsyncGraphClientinclient.py.add()to includesource_description.Episodemodel inepisode.pyto includesource_descriptionas an optional field.2.10.0to2.10.1inpyproject.tomlandclient_wrapper.py.This description was created by
for 145126c. It will automatically update as commits are pushed.