Skip to content

add embedder tests #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions tests/embedder/embedder_fixtures.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
"""
Copyright 2024, Zep Software, Inc.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
"""


def create_embedding_values(multiplier: float = 0.1, dimension: int = 1536) -> list[float]:
"""Create embedding values with the specified multiplier and dimension."""
return [multiplier] * dimension
127 changes: 127 additions & 0 deletions tests/embedder/test_gemini.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,127 @@
"""
Copyright 2024, Zep Software, Inc.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
"""

from collections.abc import Generator
from typing import Any
from unittest.mock import AsyncMock, MagicMock, patch

import pytest

from graphiti_core.embedder.gemini import (
DEFAULT_EMBEDDING_MODEL,
GeminiEmbedder,
GeminiEmbedderConfig,
)
from tests.embedder.embedder_fixtures import create_embedding_values


def create_gemini_embedding(multiplier: float = 0.1) -> MagicMock:
"""Create a mock Gemini embedding with specified value multiplier."""
mock_embedding = MagicMock()
mock_embedding.values = create_embedding_values(multiplier)
return mock_embedding


@pytest.fixture
def mock_gemini_response() -> MagicMock:
"""Create a mock Gemini embeddings response."""
mock_result = MagicMock()
mock_result.embeddings = [create_gemini_embedding()]
return mock_result


@pytest.fixture
def mock_gemini_batch_response() -> MagicMock:
"""Create a mock Gemini batch embeddings response."""
mock_result = MagicMock()
mock_result.embeddings = [
create_gemini_embedding(0.1),
create_gemini_embedding(0.2),
create_gemini_embedding(0.3),
]
return mock_result


@pytest.fixture
def mock_gemini_client() -> Generator[Any, Any, None]:
"""Create a mocked Gemini client."""
with patch('google.genai.Client') as mock_client:
mock_instance = mock_client.return_value
mock_instance.aio = MagicMock()
mock_instance.aio.models = MagicMock()
mock_instance.aio.models.embed_content = AsyncMock()
yield mock_instance


@pytest.fixture
def gemini_embedder(mock_gemini_client: Any) -> GeminiEmbedder:
"""Create a GeminiEmbedder with a mocked client."""
config = GeminiEmbedderConfig(api_key='test_api_key')
client = GeminiEmbedder(config=config)
client.client = mock_gemini_client
return client


@pytest.mark.asyncio
async def test_create_calls_api_correctly(
gemini_embedder: GeminiEmbedder, mock_gemini_client: Any, mock_gemini_response: MagicMock
) -> None:
"""Test that create method correctly calls the API and processes the response."""
# Setup
mock_gemini_client.aio.models.embed_content.return_value = mock_gemini_response

# Call method
result = await gemini_embedder.create('Test input')

# Verify API is called with correct parameters
mock_gemini_client.aio.models.embed_content.assert_called_once()
_, kwargs = mock_gemini_client.aio.models.embed_content.call_args
assert kwargs['model'] == DEFAULT_EMBEDDING_MODEL
assert kwargs['contents'] == ['Test input']

# Verify result is processed correctly
assert result == mock_gemini_response.embeddings[0].values


@pytest.mark.asyncio
async def test_create_batch_processes_multiple_inputs(
gemini_embedder: GeminiEmbedder, mock_gemini_client: Any, mock_gemini_batch_response: MagicMock
) -> None:
"""Test that create_batch method correctly processes multiple inputs."""
# Setup
mock_gemini_client.aio.models.embed_content.return_value = mock_gemini_batch_response
input_batch = ['Input 1', 'Input 2', 'Input 3']

# Call method
result = await gemini_embedder.create_batch(input_batch)

# Verify API is called with correct parameters
mock_gemini_client.aio.models.embed_content.assert_called_once()
_, kwargs = mock_gemini_client.aio.models.embed_content.call_args
assert kwargs['model'] == DEFAULT_EMBEDDING_MODEL
assert kwargs['contents'] == input_batch

# Verify all results are processed correctly
assert len(result) == 3
assert result == [
mock_gemini_batch_response.embeddings[0].values,
mock_gemini_batch_response.embeddings[1].values,
mock_gemini_batch_response.embeddings[2].values,
]


if __name__ == '__main__':
pytest.main(['-xvs', __file__])
126 changes: 126 additions & 0 deletions tests/embedder/test_openai.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,126 @@
"""
Copyright 2024, Zep Software, Inc.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
"""

from collections.abc import Generator
from typing import Any
from unittest.mock import AsyncMock, MagicMock, patch

import pytest

from graphiti_core.embedder.openai import (
DEFAULT_EMBEDDING_MODEL,
OpenAIEmbedder,
OpenAIEmbedderConfig,
)
from tests.embedder.embedder_fixtures import create_embedding_values


def create_openai_embedding(multiplier: float = 0.1) -> MagicMock:
"""Create a mock OpenAI embedding with specified value multiplier."""
mock_embedding = MagicMock()
mock_embedding.embedding = create_embedding_values(multiplier)
return mock_embedding


@pytest.fixture
def mock_openai_response() -> MagicMock:
"""Create a mock OpenAI embeddings response."""
mock_result = MagicMock()
mock_result.data = [create_openai_embedding()]
return mock_result


@pytest.fixture
def mock_openai_batch_response() -> MagicMock:
"""Create a mock OpenAI batch embeddings response."""
mock_result = MagicMock()
mock_result.data = [
create_openai_embedding(0.1),
create_openai_embedding(0.2),
create_openai_embedding(0.3),
]
return mock_result


@pytest.fixture
def mock_openai_client() -> Generator[Any, Any, None]:
"""Create a mocked OpenAI client."""
with patch('openai.AsyncOpenAI') as mock_client:
mock_instance = mock_client.return_value
mock_instance.embeddings = MagicMock()
mock_instance.embeddings.create = AsyncMock()
yield mock_instance


@pytest.fixture
def openai_embedder(mock_openai_client: Any) -> OpenAIEmbedder:
"""Create an OpenAIEmbedder with a mocked client."""
config = OpenAIEmbedderConfig(api_key='test_api_key')
client = OpenAIEmbedder(config=config)
client.client = mock_openai_client
return client


@pytest.mark.asyncio
async def test_create_calls_api_correctly(
openai_embedder: OpenAIEmbedder, mock_openai_client: Any, mock_openai_response: MagicMock
) -> None:
"""Test that create method correctly calls the API and processes the response."""
# Setup
mock_openai_client.embeddings.create.return_value = mock_openai_response

# Call method
result = await openai_embedder.create('Test input')

# Verify API is called with correct parameters
mock_openai_client.embeddings.create.assert_called_once()
_, kwargs = mock_openai_client.embeddings.create.call_args
assert kwargs['model'] == DEFAULT_EMBEDDING_MODEL
assert kwargs['input'] == 'Test input'

# Verify result is processed correctly
assert result == mock_openai_response.data[0].embedding[: openai_embedder.config.embedding_dim]


@pytest.mark.asyncio
async def test_create_batch_processes_multiple_inputs(
openai_embedder: OpenAIEmbedder, mock_openai_client: Any, mock_openai_batch_response: MagicMock
) -> None:
"""Test that create_batch method correctly processes multiple inputs."""
# Setup
mock_openai_client.embeddings.create.return_value = mock_openai_batch_response
input_batch = ['Input 1', 'Input 2', 'Input 3']

# Call method
result = await openai_embedder.create_batch(input_batch)

# Verify API is called with correct parameters
mock_openai_client.embeddings.create.assert_called_once()
_, kwargs = mock_openai_client.embeddings.create.call_args
assert kwargs['model'] == DEFAULT_EMBEDDING_MODEL
assert kwargs['input'] == input_batch

# Verify all results are processed correctly
assert len(result) == 3
assert result == [
mock_openai_batch_response.data[0].embedding[: openai_embedder.config.embedding_dim],
mock_openai_batch_response.data[1].embedding[: openai_embedder.config.embedding_dim],
mock_openai_batch_response.data[2].embedding[: openai_embedder.config.embedding_dim],
]


if __name__ == '__main__':
pytest.main(['-xvs', __file__])
Loading