-
Notifications
You must be signed in to change notification settings - Fork 5
Release/3.14.0 #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Release/3.14.0 #319
Conversation
…defaults SDK-2386 updated examples
IN-5590: Update support link
…Retrieve Qr, Retrieve Receipt Added ShareV2 Create Session, retrieve session, Create Qr, Retrieve Qr, Retrieve Receipt
…sion-update SDK:2230-Expose-share-v2-api-version-update
#302) * SDK-2370: Added support for Advanced Identity Profiles Requirements for Share V2 * SDK-2370: renamed file and fixed spelling --------- Co-authored-by: System Administrator <>
…-in-session-config Sdk 2469 go idv support brand id in session config
…dia-in-the-idv-sdk SDK-2498 addedsupport for ephemeral media
…configure-consent-screen-location
…g-to-configure-consent-screen-location added configure-consent-screen-location and tests
* added darkmode and tests * updated to correct sonarqube issue
* SDK-2356: Added ErrorReason to SharedReceiptResponse * SDK-2356: Separated RequirementsNotMetDetail into type * SDK-2356: Added Unit Test for Failure Receipt
* added face capture * added retrieve methods * added tests * added face-capture controller * added static liveness response on getsession config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the digital identity example to render detailed error reasons when share receipts fail requirements, and adjusts various supporting files to align with Release 3.14.0.
- Added
ErrorReason
andRequirementsNotMetDetail
to the shared receipt model and example templates. - Introduced
requirements_not_met_detail.html
and updatederror_receipt.html
& Go handlers to display structured failure details. - Minor tweaks to Go versions, dependency references, and example workflows.
Reviewed Changes
Copilot reviewed 181 out of 181 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
_examples/digitalidentity/requirements_not_met_detail.html | New table template to render each failure detail |
_examples/digitalidentity/error_receipt.html | Updated to iterate over and include detailed error templates |
_examples/digitalidentity/receipt.go | Parses error response and executes new error templates |
_examples/digitalidentity/main.go | Builds sessions; note redirect URI typo |
_examples/digitalidentity/login.html | Go template usage mixed with Thymeleaf attributes |
README.md | Bumped SDK version and support link |
examples/… | Updated Go versions and imports in AML example |
Comments suppressed due to low confidence (1)
_examples/digitalidentity/requirements_not_met_detail.html:19
- [nitpick] The header label
DocumentCountryIsoCode
is not user-friendly. Consider renaming it to something likeDocument Country ISO Code
for readability.
<td>DocumentCountryIsoCode</td>
func receipt(w http.ResponseWriter, r *http.Request) { | ||
didClient, err := initialiseDigitalIdentityClient() | ||
if err != nil { | ||
fmt.Fprintf(w, "Client could't be generated") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo in the error message: "could't" should be "couldn't".
fmt.Fprintf(w, "Client could't be generated") | |
fmt.Fprintf(w, "Client couldn't be generated") |
Copilot uses AI. Check for mistakes.
"subject_id": "unique-user-id-for-examples" | ||
}`) | ||
|
||
sessionReq, err := (&digitalidentity.ShareSessionRequestBuilder{}).WithPolicy(policy).WithRedirectUri("https:/www.yoti.com").WithSubject(subject).Build() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The redirect URI is malformed (missing a slash); it should be https://www.yoti.com
.
sessionReq, err := (&digitalidentity.ShareSessionRequestBuilder{}).WithPolicy(policy).WithRedirectUri("https:/www.yoti.com").WithSubject(subject).Build() | |
sessionReq, err := (&digitalidentity.ShareSessionRequestBuilder{}).WithPolicy(policy).WithRedirectUri("https://www.yoti.com").WithSubject(subject).Build() |
Copilot uses AI. Check for mistakes.
func generateSession(w http.ResponseWriter, r *http.Request) { | ||
didClient, err := initialiseDigitalIdentityClient() | ||
if err != nil { | ||
fmt.Fprintf(w, "Client could't be generated: %v", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in the error message: change "could't" to "couldn't".
fmt.Fprintf(w, "Client could't be generated: %v", err) | |
fmt.Fprintf(w, "Client couldn't be generated: %v", err) |
Copilot uses AI. Check for mistakes.
<img class="yoti-logo-image" src="/static/assets/logo.png" srcset="/static/assets/logo@2x.png 2x" alt="Yoti"/> | ||
</div> | ||
|
||
<h2 th:text="${message}">Digital Identity Share Example page</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This uses Thymeleaf (th:text
) instead of Go template syntax. Use {{ .message }}
or remove the th:text
attribute so Go can render correctly.
<h2 th:text="${message}">Digital Identity Share Example page</h2> | |
<h2>{{ .message }}</h2> |
Copilot uses AI. Check for mistakes.
Added
Expanded SharedReceiptResponse to include details about the error:
Before:
After: