Sdk 1988 go add support for fetching session configuration #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for fetching the session configuration for Doc Scan (IDV) sessions. It adds new configuration types and accessor methods, a client method to retrieve session configuration via a GET endpoint, and corresponding example routes and handlers.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docscan/config/config_retrieve.go | Introduced types and getters for session configuration information. |
| docscan/client.go | Added a client method to fetch session configuration from the API endpoint. |
| _examples/idv/routes.go | Added a new route for session configuration retrieval in the example app. |
| _examples/idv/handlers.session.go | Implemented a handler to process session configuration retrieval requests. |
Comments suppressed due to low confidence (1)
_examples/idv/handlers.session.go:235
- [nitpick] For consistency with common naming conventions, consider using a lowercase query parameter (e.g., 'session_id') to ensure uniformity across the API.
sessionID := c.Query("SessionID") // Get the SessionID from the query parameters
|
Quality gate has failed. Please check code coverage. |
saurabh-yoti
requested changes
May 14, 2025
| @@ -291,3 +292,40 @@ func marshalJSON(jsonMarshaler jsonMarshaler, v interface{}) ([]byte, error) { | |||
| } | |||
| return json.Marshal(v) | |||
| } | |||
|
|
|||
| const getSessionConfigurationPath = "/sessions/%s/configuration" | |||
There was a problem hiding this comment.
Please move this to docscan/endpoint.go for consistency.
There was a problem hiding this comment.
We need to add filters for returning Document, Liveness and Face capture resource requirements similar to the Node SDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.