Add custom protocol config #55
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds backend support for `protocol.custom-message`, `protocol.custom-init`, and `protocol.custom-nodeann`, allowing node runners to handle messages separately from the LND instance. This enables running LNDK to handle onion messages in a shim alongside LND.
This commit adds a new "Protocol" settings group to the `AdvancedSettingsModal` with three new configuration options: - protocol.custom-message: Custom message handling number - protocol.custom-init: Custom feature bit for init messages - protocol.custom-nodeann: Custom feature bit for node announcements Each setting accepts a number or null value and updates the umbrel-lnd.conf file accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to run LNDK along side my umbrel LND node I needed to modify manually the
umbrel-lnd.confto make it work (ssh into it and then modify it).I would like to publish an app for LNDK to Umbrel but users would need to do some manual modification of their node or have a trigger button for it. Then, I thought adding these settings makes sense so their modification are only done through the same UI of their node and we could walkthrough them to it.
Then, this PR has 3 parts:
AdvancedSettingsModalthat takes care of adding the configuration.Happy to discuss if this approach makes sense.