Skip to content

Conversation

@sandstrom
Copy link

  • Use https for links
  • Move license info down to relevant section (no need to have it at the top)

Copy link
Owner

@gettalong gettalong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request! I have added some comments for changes that should not be done.

README.md Outdated
## Introduction

kramdown is a fast, pure Ruby Markdown superset converter, using a strict syntax definition and
kramdown is a fast, pure Ruby Markdown converter, using a strict syntax definition and
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kramdown does not just convert Markdown but really a Markdown superset. So please remove that change.

README.md Outdated
**doc/quickref.page** or online at <https://kramdown.gettalong.org/quickref.html>.

The kramdown library is mainly written to support the kramdown-to-HTML conversion chain. However,
The kramdown library is mainly written to support the markdown-to-HTML conversion chain. However,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using "kramdown" instead of "Markdown" is done intentionally as kramdown-the-syntax is more than Markdown-the-syntax. Markdown is "another input format".

If you use kramdown in a commercial setting, please consider contributing back any
changes for the benefit of the community, or [becoming a sponsor](https://github.com/sponsors/gettalong/)
or [a patron](https://www.patreon.com/gettalong) - thanks!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the original wording.

@sandstrom
Copy link
Author

@gettalong I've updated the PR, trying to match your comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants