🔧 chore(data-secrecy v2): SafeDelete DataSecrecyWaiver #95464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Comment on lines
-668
to
-677
| DataSecrecyWaiver.objects.create( | ||
| organization=org, | ||
| access_start=timezone.now(), | ||
| access_end=timezone.now() + timedelta(days=1), | ||
| ) |
There was a problem hiding this comment.
Any idea what this was previously used for?
There was a problem hiding this comment.
It's just boilerplate stuff that you sometimes need to add when adding a new model
GabeVillalobos
approved these changes
Jul 14, 2025
|
This PR has a migration; here is the generated SQL for for --
-- Moved model DataSecrecyWaiver to pending deletion state
--
-- (no-op) |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #95464 +/- ##
===========================================
+ Coverage 32.95% 76.30% +43.35%
===========================================
Files 8999 10548 +1549
Lines 503908 607954 +104046
Branches 23825 23825
===========================================
+ Hits 166038 463892 +297854
+ Misses 337574 142167 -195407
- Partials 296 1895 +1599 |
wedamija
approved these changes
Jul 15, 2025
Comment on lines
-668
to
-677
| DataSecrecyWaiver.objects.create( | ||
| organization=org, | ||
| access_start=timezone.now(), | ||
| access_end=timezone.now() + timedelta(days=1), | ||
| ) |
There was a problem hiding this comment.
It's just boilerplate stuff that you sometimes need to add when adding a new model
iamrajjoshi
force-pushed
the
raj/ds-v2/deprecate-v1/delete-model-2
branch
from
ada5a1f to
d1bcda9
Compare
|
This PR has a migration; here is the generated SQL for for --
-- Moved model DataSecrecyWaiver to pending deletion state
--
-- (no-op) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #95393
contributes to ECO-824