ref(feedback): Replace react-virtualized with @tanstack/react-virtual in Feedback
#95398
+278
−218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ryan953
force-pushed
the
ryan953/partial-focus-fix-conflicts-with-open-pr
branch
from
75f9749 to
b6c6c3a
Compare
ryan953
commented
Jul 12, 2025
| flex-grow: 1; | ||
| min-height: 300px; | ||
| padding-bottom: ${space(0.5)}; |
There was a problem hiding this comment.
This is to add spacing under the last item shown
ryan953
commented
Jul 12, 2025
Comment on lines
+94
to
96
| const Centered = styled('div')` | ||
| justify-self: center; | ||
| `; |
There was a problem hiding this comment.
No more absolute positioning for the 'loading more' spinner
Before
After
ryan953
commented
Jul 12, 2025
Comment on lines
-178
to
-180
| position: relative; | ||
| top: 50%; | ||
| transform: translateY(-50%); |
There was a problem hiding this comment.
This isn't needed anymore
`@tanstack/react-virtual` in Feedback
ryan953
force-pushed
the
ryan953/partial-focus-fix-conflicts-with-open-pr
branch
from
b6c6c3a to
e35a094
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
billyvg
approved these changes
Jul 15, 2025
Comment on lines
+50
to
+58
| return <p>Loading...</p>; | ||
| } | ||
|
|
||
| function ErrorMessage({error}: {error: Error}) { | ||
| return <p>Error: {error.message}</p>; | ||
| } | ||
|
|
||
| function BackgroundUpdatingMessage() { | ||
| return <footer>Background Updating...</footer>; |
| @@ -0,0 +1,13 @@ | |||
| export default function uniqueBy<Data extends Record<string, unknown>>( | |||
There was a problem hiding this comment.
let's rename the file uniqueBy to match this fn?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list still looks the same, this was surprisingly easy actually.
2 helper files i pulled in from sentry-toolbar (InfiniteListItems, InfiniteListState) made it easier too, they wrap a bunch of state conditions and also wrap the load-more triggers which really cleanup this
<FeedbackList>component now.Related to https://github.com/getsentry/frontend-tsc/issues/91