stories: implement programmatic pagination detection #95397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bug: Story Pagination Fails Due to Property Mismatch
The findPreviousAndNextStory function incorrectly compares s.story.filesystemPath (from StoryTreeNode) with story.filename (from StoryDescriptor). This property name mismatch means the values may differ, preventing the current story from being found. As a result, the function returns null, breaking story pagination and preventing previous/next navigation links from being displayed.
static/app/stories/view/storyFooter.tsx#L77-L78
sentry/static/app/stories/view/storyFooter.tsx
Lines 77 to 78 in 32d17ea
Was this report helpful? Give feedback by reacting with 👍 or 👎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement programmatic pagination detection in the story tree, which won't require manual link maintenance.