stories: fix api reference table #95396
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Bug: MDX Stories Render Empty Tables Incorrectly
The StoryResources component now incorrectly renders an empty table (headers only) for MDX stories that lack resources. Previously, it would return null if story.exports.frontmatter?.resources was undefined. The updated logic removes this check, instead only checking !isMDXStory(story) for an early exit, and defaults resources to an empty object, causing the table to render for all MDX stories regardless of resource availability.
static/app/stories/view/storyResources.tsx#L13-L18
sentry/static/app/stories/view/storyResources.tsx
Lines 13 to 18 in 632d05e
Was this report helpful? Give feedback by reacting with 👍 or 👎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes API reference table - we need to export only the types we want to show, as some components will have multiple. I have also improved the story types, which surfaced some potential runtime cases we weren't handling correctly