Skip to content

ref(billing): recordAnalytics #95394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025
Merged

ref(billing): recordAnalytics #95394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 17 additions & 19 deletions static/gsApp/views/amCheckout/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,10 @@ export function getEventsWithUnit(
return events;
}

type CheckoutData = {
plan: string;
} & Partial<Record<DataCategory, number>>;

function recordAnalytics(
organization: Organization,
subscription: Subscription,
Expand All @@ -371,31 +375,25 @@ function recordAnalytics(
) {
trackMarketingEvent('Upgrade', {plan: data.plan});

const currentData = {
// TODO(data categories): BIL-966
const currentData: CheckoutData = {
plan: data.plan,
errors: data.reservedErrors,
transactions: data.reservedTransactions,
attachments: data.reservedAttachments,
replays: data.reservedReplays,
monitorSeats: data.reservedMonitorSeats,
spans: data.reservedSpans,
profileDuration: data.reservedProfileDuration,
uptime: data.reservedUptime,
};

const previousData = {
Object.keys(data).forEach(key => {
if (key.startsWith('reserved')) {
const targetKey = key.charAt(8).toLowerCase() + key.slice(9);
(currentData as any)[targetKey] = data[key as keyof CheckoutAPIData];
}
});

const previousData: CheckoutData = {
plan: subscription.plan,
errors: subscription.categories.errors?.reserved || undefined,
transactions: subscription.categories.transactions?.reserved || undefined,
attachments: subscription.categories.attachments?.reserved || undefined,
replays: subscription.categories.replays?.reserved || undefined,
monitorSeats: subscription.categories.monitorSeats?.reserved || undefined,
profileDuration: subscription.categories.profileDuration?.reserved || undefined,
spans: subscription.categories.spans?.reserved || undefined,
uptime: subscription.categories.uptime?.reserved || undefined,
};

Object.entries(subscription.categories).forEach(([category, value]) => {
(previousData as any)[category] = value?.reserved || undefined;
});

// TODO(reserved budgets): in future, we should just be able to pass data.selectedProducts
const selectableProductData = {
[SelectableProduct.SEER]: {
Expand Down
Loading