Skip to content

🔧 chore(data-secrecy v2): prep DataSecrecyWaiver model to be deleted #95393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion migrations_lockfile.txt
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ preprod: 0010_actual_drop_preprod_artifact_analysis_file_id_col

replays: 0006_add_bulk_delete_job

sentry: 0947_add_dashboard_last_visited_model
sentry: 0948_ds_waiver_org_fk_not_db_constr

social_auth: 0003_social_auth_json_field

Expand Down
2 changes: 1 addition & 1 deletion src/sentry/data_secrecy/models/datasecrecywaiver.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
class DataSecrecyWaiver(DefaultFieldsModelExisting):
__relocation_scope__ = RelocationScope.Organization

organization = FlexibleForeignKey("sentry.Organization", unique=True)
organization = FlexibleForeignKey("sentry.Organization", unique=True, db_constraint=False)
access_start = models.DateTimeField(default=timezone.now)
access_end = models.DateTimeField(default=timezone.now)
zendesk_tickets = ArrayField(models.TextField(), default=list)
Expand Down
40 changes: 40 additions & 0 deletions src/sentry/migrations/0948_ds_waiver_org_fk_not_db_constr.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# Generated by Django 5.2.1 on 2025-07-11 23:13

import django.db.models.deletion
from django.db import migrations

import sentry.db.models.fields.foreignkey
from sentry.new_migrations.migrations import CheckedMigration


class Migration(CheckedMigration):
# This flag is used to mark that a migration shouldn't be automatically run in production.
# This should only be used for operations where it's safe to run the migration after your
# code has deployed. So this should not be used for most operations that alter the schema
# of a table.
# Here are some things that make sense to mark as post deployment:
# - Large data migrations. Typically we want these to be run manually so that they can be
# monitored and not block the deploy for a long period of time while they run.
# - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
# run this outside deployments so that we don't block them. Note that while adding an index
# is a schema change, it's completely safe to run the operation after the code has deployed.
# Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment

is_post_deployment = False

dependencies = [
("sentry", "0947_add_dashboard_last_visited_model"),
]

operations = [
migrations.AlterField(
model_name="datasecrecywaiver",
name="organization",
field=sentry.db.models.fields.foreignkey.FlexibleForeignKey(
db_constraint=False,
on_delete=django.db.models.deletion.CASCADE,
to="sentry.organization",
unique=True,
),
),
]
Loading