-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
ref(feedback): move userreport ingest and endpoints to feedback module #95392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@@ -32,6 +35,9 @@ def save_feedback_event(event_data: Mapping[str, Any], project_id: int): | |||
|
|||
try: | |||
# Shim to UserReport | |||
# TODO: this logic should be extracted to a shim_to_userreport function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing in the next follow up
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Re: cursor - yes this is a metrics change I intentionally bundled in. We don't have a dashboard widget or monitor on this metric so going to rename it to match the other metrics in the file |
todo in follow-up: make a way to share |
User reports are the same product as feedback and owned by replay team. I'd like to move the code here for organizational purposes. Same goes for the feedback summary endpoint. This PR only moves things around, no implementation changes.
Ref REPLAY-513: [PR Tracker] refactor backend user feedback code
I plan to follow up with quality improvements to the ingest functions, making them more composable, so the ingest/usecases modules are subject to change.