Skip to content

ref(feedback): move userreport ingest and endpoints to feedback module #95392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Jul 11, 2025

User reports are the same product as feedback and owned by replay team. I'd like to move the code here for organizational purposes. Same goes for the feedback summary endpoint. This PR only moves things around, no implementation changes.

Ref REPLAY-513: [PR Tracker] refactor backend user feedback code

I plan to follow up with quality improvements to the ingest functions, making them more composable, so the ingest/usecases modules are subject to change.

@aliu39 aliu39 requested review from a team as code owners July 11, 2025 23:12
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 11, 2025
@@ -32,6 +35,9 @@ def save_feedback_event(event_data: Mapping[str, Any], project_id: int):

try:
# Shim to UserReport
# TODO: this logic should be extracted to a shim_to_userreport function
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing in the next follow up

cursor[bot]

This comment was marked as outdated.

Copy link

codecov bot commented Jul 11, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
27196 1 27195 232
View the top 1 failed test(s) by shortest run time
tests.sentry.llm.test_openai::test_complete_prompt
Stack Traces | 0.051s run time
#x1B[1m#x1B[.../sentry/llm/test_openai.py#x1B[0m:38: in test_complete_prompt
    assert res == ""
#x1B[1m#x1B[31mE   AssertionError: assert 'not spam' == ''#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     + not spam#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@aliu39
Copy link
Member Author

aliu39 commented Jul 11, 2025

Re: cursor - yes this is a metrics change I intentionally bundled in. We don't have a dashboard widget or monitor on this metric so going to rename it to match the other metrics in the file

@aliu39
Copy link
Member Author

aliu39 commented Jul 12, 2025

todo in follow-up: make a way to share mock_produce_occurrence patching logic, so paths don't have to be changed in so many test files every time we move or rename things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant