-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
ref(explore): add some missing default renderers to getFieldRenderer #95231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
ref(explore): add some missing default renderers to getFieldRenderer #95231
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #95231 +/- ##
===========================================
+ Coverage 72.66% 85.34% +12.68%
===========================================
Files 10469 10448 -21
Lines 605430 603573 -1857
Branches 23677 23517 -160
===========================================
+ Hits 439908 515095 +75187
+ Misses 165001 88114 -76887
+ Partials 521 364 -157 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Malformed Project Links with Trailing Slash
The project_id
field renderer generates malformed URLs for project links. The path constructed, /${project?.slug}/?project=${projectId}/
, incorrectly includes a trailing slash after the query parameter, creating an invalid URL format. The trailing slash should be removed.
static/app/utils/discover/fieldRenderers.tsx#L683-L690
sentry/static/app/utils/discover/fieldRenderers.tsx
Lines 683 to 690 in 811bebd
} | |
const target = makeProjectsPathname({ | |
path: `/${project?.slug}/?project=${projectId}/`, | |
organization, | |
}); | |
return <Link to={target}>{projectId}</Link>; | |
}} |
Was this report helpful? Give feedback by reacting with 👍 or 👎
Changes
There exists some cell renderers that exist throughout Sentry that should be used as defaults in the general renderer. This PR tries to add as many of them.
For a clear list of renderers added: refer to https://linear.app/getsentry/issue/DAIN-690/add-more-standard-renderers-for-event-data. I also have a dashboard that showcases these renderers:
dashboard/138017/