ref(insights): remove eap conditions web vitals #95228
Merged
+46
−367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #95228 +/- ##
==========================================
+ Coverage 84.06% 87.85% +3.78%
==========================================
Files 10470 10469 -1
Lines 605507 605253 -254
Branches 23681 23655 -26
==========================================
+ Hits 509042 531736 +22694
+ Misses 96105 73157 -22948
Partials 360 360 |
gggritso
reviewed
Jul 10, 2025
static/app/views/insights/browser/webVitals/components/pageOverviewWebVitalsDetailPanel.tsx
Outdated
Show resolved
Hide resolved
static/app/views/insights/browser/webVitals/components/pageOverviewWebVitalsDetailPanel.tsx
Show resolved
Hide resolved
edwardgou-sentry
approved these changes
Jul 10, 2025
…ditionals-web-vitals
|
@gggritso I resolved your comments and also fixed some unit tests since you last reviewed! |
gggritso
approved these changes
Jul 10, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
DominikB2014
deleted the
dominikbuszowiecki/dain-724-remove-eap-conditionals-web-vitals
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove eap conditions in webvitals now that its 100% GA