Skip to content

ref: replace consistent-type-imports with verbatimModuleSyntax #95225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 49 commits into from
Jul 15, 2025
Merged

ref: replace consistent-type-imports with verbatimModuleSyntax #95225

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
f18ad64
test(ui): jest 30
scttcper Jun 11, 2025
0d87afa
update jest lint
scttcper Jun 11, 2025
8af1279
bump sentry-env
scttcper Jun 16, 2025
09af760
more progress on jest 30
scttcper Jun 16, 2025
3b5766a
switch more tests to testable assign
scttcper Jun 16, 2025
bf44fa6
convert a few more tests
scttcper Jun 16, 2025
b9f2cdd
Merge branch 'master' into scttcper/jest-30
scttcper Jun 16, 2025
f3c4c9f
fix more location use
scttcper Jun 17, 2025
2faec4d
lockfile
scttcper Jun 17, 2025
ba9d227
remove babel runtime, set target
scttcper Jun 17, 2025
aae787f
Merge branch 'master' into scttcper/jest-30
scttcper Jun 17, 2025
3edf4f4
give up
scttcper Jun 17, 2025
9cfa2ca
add comment
scttcper Jun 17, 2025
8ae55a7
Merge branch 'master' into scttcper/jest-30
scttcper Jun 17, 2025
1bb2731
Merge branch 'master' into scttcper/jest-30
scttcper Jun 17, 2025
7add448
rename
scttcper Jun 17, 2025
4822931
limit functionality via types
scttcper Jun 17, 2025
8540224
whoops
scttcper Jun 17, 2025
594a66d
Merge branch 'master' into scttcper/jest-30
scttcper Jun 18, 2025
b9c9a3f
Merge branch 'master' into scttcper/jest-30
scttcper Jun 18, 2025
41bc3a6
Merge branch 'master' into scttcper/jest-30
scttcper Jun 24, 2025
3ccb400
Merge branch 'master' into scttcper/jest-30
scttcper Jun 24, 2025
920f4a9
bump version, add experimental-transform-types
scttcper Jun 24, 2025
2b6e661
locate __dirname closer to use
scttcper Jun 24, 2025
39346b0
add same thing to knip
scttcper Jun 24, 2025
c4f1d01
Merge branch 'master' into scttcper/jest-30
scttcper Jun 25, 2025
a8a362d
bump 30.0.3
scttcper Jun 25, 2025
c7b0f5f
Merge branch 'master' into scttcper/jest-30
scttcper Jul 1, 2025
0e33012
remove container silence
scttcper Jul 1, 2025
574b977
remove another silenced warning
scttcper Jul 1, 2025
c99f30a
use newer import.meta.dirname
scttcper Jul 1, 2025
88cacd5
bump babel
scttcper Jul 1, 2025
6bc141a
Merge branch 'master' into scttcper/jest-30
scttcper Jul 1, 2025
be6d14f
revert removal
scttcper Jul 1, 2025
f3b35a1
Merge branch 'master' into scttcper/jest-30
scttcper Jul 1, 2025
9d0d762
Merge branch 'master' into scttcper/jest-30
scttcper Jul 8, 2025
93da88d
bump patch version
scttcper Jul 8, 2025
ca3f8ab
remove a new window.location assignment
scttcper Jul 8, 2025
0f77d54
ref: replace consistent-type-imports with verbatimModuleSyntax
TkDodo Jul 10, 2025
49c50d6
ref: move DEFAULT_QUERY into issueList/utils
TkDodo Jul 10, 2025
d540b90
ref: remaining imports
TkDodo Jul 10, 2025
6e9647d
fix: test execution
TkDodo Jul 10, 2025
48f46ec
fix: set TS_NODE_PROJECT for knip
TkDodo Jul 10, 2025
2077291
Merge branch 'master' into scttcper/jest-30
scttcper Jul 10, 2025
378ab2c
Merge branch 'master' into scttcper/jest-30
scttcper Jul 10, 2025
7b89cd5
Merge branch 'master' into tkdodo/ref/verbatimModuleSyntax
TkDodo Jul 14, 2025
f7cac73
Merge branch scttcper/jest-30
TkDodo Jul 14, 2025
5714dea
ref: rebase onto 93303 so we don't need the special jest tsconfig
TkDodo Jul 14, 2025
0b8470d
Merge branch 'master' into tkdodo/ref/verbatimModuleSyntax
TkDodo Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/tsconfig.base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@
"esModuleInterop": true,
"experimentalDecorators": true,
"resolveJsonModule": true,
"verbatimModuleSyntax": true,

"paths": {
"sentry/*": ["../static/app/*"],
Expand Down
1 change: 0 additions & 1 deletion eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,6 @@ export default typescript.config([
? {
'@typescript-eslint/await-thenable': 'error',
'@typescript-eslint/consistent-type-exports': 'error',
'@typescript-eslint/consistent-type-imports': 'error',
'@typescript-eslint/no-array-delete': 'error',
'@typescript-eslint/no-base-to-string': 'error',
'@typescript-eslint/no-for-in-array': 'error',
Expand Down
1 change: 0 additions & 1 deletion static/app/constants/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,6 @@ export const MAX_PICKABLE_DAYS = 90;

export const DEFAULT_STATS_PERIOD = '14d';

export const DEFAULT_QUERY = 'is:unresolved issue.priority:[high, medium]';
export const TAXONOMY_DEFAULT_QUERY = 'is:unresolved';

export const DEFAULT_USE_UTC = true;
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/issueList/actions/index.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ import {
} from 'sentry-test/reactTestingLibrary';

import GlobalModal from 'sentry/components/globalModal';
import {DEFAULT_QUERY} from 'sentry/constants';
import GroupStore from 'sentry/stores/groupStore';
import SelectedGroupStore from 'sentry/stores/selectedGroupStore';
import {IssueCategory} from 'sentry/types/group';
import * as analytics from 'sentry/utils/analytics';
import {IssueListActions} from 'sentry/views/issueList/actions';
import {DEFAULT_QUERY} from 'sentry/views/issueList/utils';

const organization = OrganizationFixture();

Expand Down
3 changes: 1 addition & 2 deletions static/app/views/issueList/issueListSetAsDefault.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,9 @@ import {SearchFixture} from 'sentry-fixture/search';
import {initializeOrg} from 'sentry-test/initializeOrg';
import {render, screen, userEvent, waitFor} from 'sentry-test/reactTestingLibrary';

import {DEFAULT_QUERY} from 'sentry/constants';
import {SavedSearchType, SavedSearchVisibility} from 'sentry/types/group';
import IssueListSetAsDefault from 'sentry/views/issueList/issueListSetAsDefault';
import {IssueSortOptions} from 'sentry/views/issueList/utils';
import {DEFAULT_QUERY, IssueSortOptions} from 'sentry/views/issueList/utils';

describe('IssueListSetAsDefault', () => {
const organization = OrganizationFixture();
Expand Down
3 changes: 1 addition & 2 deletions static/app/views/issueList/noGroupsHandler/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,11 @@ import type {Client} from 'sentry/api';
import EmptyStateWarning from 'sentry/components/emptyStateWarning';
import LoadingIndicator from 'sentry/components/loadingIndicator';
import Placeholder from 'sentry/components/placeholder';
import {DEFAULT_QUERY} from 'sentry/constants';
import {t} from 'sentry/locale';
import type {Organization} from 'sentry/types/organization';
import type {Project} from 'sentry/types/project';
import NoIssuesMatched from 'sentry/views/issueList/noGroupsHandler/noIssuesMatched';
import {FOR_REVIEW_QUERIES} from 'sentry/views/issueList/utils';
import {DEFAULT_QUERY, FOR_REVIEW_QUERIES} from 'sentry/views/issueList/utils';

import NoUnresolvedIssues from './noUnresolvedIssues';

Expand Down
2 changes: 1 addition & 1 deletion static/app/views/issueList/overview.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import {
} from 'sentry-test/reactTestingLibrary';
import {textWithMarkupMatcher} from 'sentry-test/utils';

import {DEFAULT_QUERY} from 'sentry/constants';
import PageFiltersStore from 'sentry/stores/pageFiltersStore';
import ProjectsStore from 'sentry/stores/projectsStore';
import TagStore from 'sentry/stores/tagStore';
Expand All @@ -28,6 +27,7 @@ import type {RouteComponentProps} from 'sentry/types/legacyReactRouter';
import localStorageWrapper from 'sentry/utils/localStorage';
import * as parseLinkHeader from 'sentry/utils/parseLinkHeader';
import IssueListOverview from 'sentry/views/issueList/overview';
import {DEFAULT_QUERY} from 'sentry/views/issueList/utils';

const DEFAULT_LINKS_HEADER =
'<http://127.0.0.1:8000/api/0/organizations/org-slug/issues/?cursor=1443575731:0:1>; rel="previous"; results="false"; cursor="1443575731:0:1", ' +
Expand Down
4 changes: 2 additions & 2 deletions static/app/views/issueList/overview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import * as Layout from 'sentry/components/layouts/thirds';
import {extractSelectionParameters} from 'sentry/components/organizations/pageFilters/utils';
import type {CursorHandler} from 'sentry/components/pagination';
import QueryCount from 'sentry/components/queryCount';
import {DEFAULT_QUERY, DEFAULT_STATS_PERIOD} from 'sentry/constants';
import {DEFAULT_STATS_PERIOD} from 'sentry/constants';
import {t, tct} from 'sentry/locale';
import GroupStore from 'sentry/stores/groupStore';
import IssueListCacheStore from 'sentry/stores/IssueListCacheStore';
Expand Down Expand Up @@ -59,7 +59,7 @@ import {usePrefersStackedNav} from 'sentry/views/nav/usePrefersStackedNav';

import IssueListFilters from './filters';
import IssueListHeader from './header';
import type {QueryCounts} from './utils';
import {DEFAULT_QUERY, type QueryCounts} from './utils';
import {
DEFAULT_ISSUE_STREAM_SORT,
FOR_REVIEW_QUERIES,
Expand Down
4 changes: 3 additions & 1 deletion static/app/views/issueList/overviewWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {DEFAULT_QUERY, TAXONOMY_DEFAULT_QUERY} from 'sentry/constants';
import {TAXONOMY_DEFAULT_QUERY} from 'sentry/constants';
import {t} from 'sentry/locale';
import type {RouteComponentProps} from 'sentry/types/legacyReactRouter';
import {defined} from 'sentry/utils';
Expand All @@ -7,6 +7,8 @@ import IssueListContainer from 'sentry/views/issueList';
import IssueListOverview from 'sentry/views/issueList/overview';
import {usePrefersStackedNav} from 'sentry/views/nav/usePrefersStackedNav';

import {DEFAULT_QUERY} from './utils';

type OverviewWrapperProps = RouteComponentProps<
Record<PropertyKey, string | undefined>,
{searchId?: string}
Expand Down
3 changes: 2 additions & 1 deletion static/app/views/issueList/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
import type {Location, LocationDescriptorObject} from 'history';

import ExternalLink from 'sentry/components/links/externalLink';
import {DEFAULT_QUERY} from 'sentry/constants';
import {t, tct} from 'sentry/locale';
import type {Event} from 'sentry/types/event';
import type {Group, GroupTombstoneHelper} from 'sentry/types/group';
import type {Organization} from 'sentry/types/organization';

export const DEFAULT_QUERY = 'is:unresolved issue.priority:[high, medium]';

export enum Query {
FOR_REVIEW = 'is:unresolved is:for_review assigned_or_suggested:[me, my_teams, none]',
PRIORITIZED = DEFAULT_QUERY, // eslint-disable-line @typescript-eslint/prefer-literal-enum-member
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: verbatimModuleSyntax also enables isolatedModules, where files must be parseable on their own. For enums, that means they can’t reference a value outside of its file, or it’ll error with:

TS18055: 'Query.PRIORITIZED' has a string type, but must have syntactically recognizable string syntax when 'isolatedModules' is enabled.

This is the only place where we had this violation (it’s also a lint violation as we can see), and since DEFAULT_QUERY is only used within views/issueList, it makes sense to inline it here, as this also makes the constant smaller in scope / less global.

Expand Down
Loading