chore(dashboards): Remove table view FF from backend (#94959)

Author: narsaynorath

src/sentry/api/endpoints/organization_dashboards.py

@@ -145,43 +145,31 @@ def get(self, request: Request, organization) -> Response:
             order_by = ["last_visited" if desc else "-last_visited"]
 
         elif sort_by == "mydashboards":
-            if features.has(
-                "organizations:dashboards-table-view", organization, actor=request.user
-            ):
-                user_name_dict = {
-                    user.id: user.name
-                    for user in user_service.get_many_by_id(
-                        ids=list(dashboards.values_list("created_by_id", flat=True))
-                    )
-                }
-                dashboards = dashboards.annotate(
-                    user_name=Case(
-                        *[
-                            When(created_by_id=user_id, then=Value(user_name))
-                            for user_id, user_name in user_name_dict.items()
-                        ],
-                        default=Value(""),
-                        output_field=CharField(),
-                    )
+            user_name_dict = {
+                user.id: user.name
+                for user in user_service.get_many_by_id(
+                    ids=list(dashboards.values_list("created_by_id", flat=True))
+                )
+            }
+            dashboards = dashboards.annotate(
+                user_name=Case(
+                    *[
+                        When(created_by_id=user_id, then=Value(user_name))
+                        for user_id, user_name in user_name_dict.items()
+                    ],
+                    default=Value(""),
+                    output_field=CharField(),
                 )
-                order_by = [
-                    Case(
-                        When(created_by_id=request.user.id, then=-1),
-                        default=1,
-                        output_field=IntegerField(),
-                    ),
-                    "-user_name" if desc else "user_name",
-                    "-date_added",
-                ]
-            else:
-                order_by = [
-                    Case(
-                        When(created_by_id=request.user.id, then=-1),
-                        default="created_by_id",
-                        output_field=IntegerField(),
-                    ),
-                    "-date_added",
-                ]
+            )
+            order_by = [
+                Case(
+                    When(created_by_id=request.user.id, then=-1),
+                    default=1,
+                    output_field=IntegerField(),
+                ),
+                "-user_name" if desc else "user_name",
+                "-date_added",
+            ]
 
         elif sort_by == "myDashboardsAndRecentlyViewed":
             order_by = [

src/sentry/features/temporary.py

@@ -98,8 +98,6 @@ def register_temporary_features(manager: FeatureManager):
     manager.add("organizations:dashboards-metrics-transition", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
     # Enable starred dashboards with reordering
     manager.add("organizations:dashboards-starred-reordering", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
-    # Enable table view on dashboards landing page
-    manager.add("organizations:dashboards-table-view", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
     # Enable the dashboard widget builder redesign UI
     manager.add("organizations:dashboards-widget-builder-redesign", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
     # Enable dashboard table widget visualization component to replace current widget tables

tests/sentry/api/endpoints/test_organization_dashboards.py

@@ -173,14 +173,7 @@ def test_get_sortby_mydashboards(self):
         assert response.status_code == 200, response.content
 
         values = [int(row["createdBy"]["id"]) for row in response.data if row["dateCreated"]]
-        assert values == [self.user.id, self.user.id, user_1.id, user_2.id]
-
-        with self.feature("organizations:dashboards-table-view"):
-            response = self.client.get(self.url, data={"sort": "mydashboards"})
-            assert response.status_code == 200, response.content
-
-            values = [int(row["createdBy"]["id"]) for row in response.data if row["dateCreated"]]
-            assert values == [self.user.id, self.user.id, user_2.id, user_1.id]
+        assert values == [self.user.id, self.user.id, user_2.id, user_1.id]
 
     def test_get_sortby_mydashboards_and_recently_viewed(self):
         user_1 = self.create_user(username="user_1")
@@ -247,37 +240,36 @@ def test_get_sortby_mydashboards_with_owner_name(self):
         Dashboard.objects.create(title="F", created_by_id=user_1.id, organization=self.organization)
 
         self.login_as(user_1)
-        with self.feature("organizations:dashboards-table-view"):
-            response = self.client.get(self.url, data={"sort": "mydashboards"})
-            assert response.status_code == 200, response.content
-
-            values = [row["createdBy"]["name"] for row in response.data if row["dateCreated"]]
-            assert values == [
-                "Cat",
-                "Cat",
-                "admin@localhost",  # name is empty
-                "admin@localhost",
-                "Aapple",
-                "Banana",
-                "Pineapple",
-                "Pineapple",
-            ]
-
-            # descending
-            response = self.client.get(self.url, data={"sort": "-mydashboards"})
-            assert response.status_code == 200, response.content
-
-            values = [row["createdBy"]["name"] for row in response.data if row["dateCreated"]]
-            assert values == [
-                "Cat",
-                "Cat",
-                "Pineapple",
-                "Pineapple",
-                "Banana",
-                "Aapple",
-                "admin@localhost",  # name is empty
-                "admin@localhost",
-            ]
+        response = self.client.get(self.url, data={"sort": "mydashboards"})
+        assert response.status_code == 200, response.content
+
+        values = [row["createdBy"]["name"] for row in response.data if row["dateCreated"]]
+        assert values == [
+            "Cat",
+            "Cat",
+            "admin@localhost",  # name is empty
+            "admin@localhost",
+            "Aapple",
+            "Banana",
+            "Pineapple",
+            "Pineapple",
+        ]
+
+        # descending
+        response = self.client.get(self.url, data={"sort": "-mydashboards"})
+        assert response.status_code == 200, response.content
+
+        values = [row["createdBy"]["name"] for row in response.data if row["dateCreated"]]
+        assert values == [
+            "Cat",
+            "Cat",
+            "Pineapple",
+            "Pineapple",
+            "Banana",
+            "Aapple",
+            "admin@localhost",  # name is empty
+            "admin@localhost",
+        ]
 
     def test_get_only_favorites_no_sort(self):
         user_1 = self.create_user(username="user_1")