chore(dashboards): Remove table view feature flag (#94958)

Remove the feature flag checks from the frontend because this feature
has been fully GA'd for a while now.

Author: narsaynorath

static/app/views/dashboards/manage/dashboardTable.spec.tsx

@@ -22,13 +22,7 @@ describe('Dashboards - DashboardTable', function () {
   let dashboardUpdateMock: jest.Mock;
   let createMock: jest.Mock;
   const organization = OrganizationFixture({
-    features: [
-      'global-views',
-      'dashboards-basic',
-      'dashboards-edit',
-      'discover-query',
-      'dashboards-table-view',
-    ],
+    features: ['global-views', 'dashboards-basic', 'dashboards-edit', 'discover-query'],
   });
 
   const {router} = initializeOrg();
@@ -286,13 +280,7 @@ describe('Dashboards - DashboardTable', function () {
 
   it('renders access column', async function () {
     const organizationWithEditAccess = OrganizationFixture({
-      features: [
-        'global-views',
-        'dashboards-basic',
-        'dashboards-edit',
-        'discover-query',
-        'dashboards-table-view',
-      ],
+      features: ['global-views', 'dashboards-basic', 'dashboards-edit', 'discover-query'],
     });
 
     render(
@@ -318,13 +306,7 @@ describe('Dashboards - DashboardTable', function () {
     });
 
     const organizationWithFavorite = OrganizationFixture({
-      features: [
-        'global-views',
-        'dashboards-basic',
-        'dashboards-edit',
-        'discover-query',
-        'dashboards-table-view',
-      ],
+      features: ['global-views', 'dashboards-basic', 'dashboards-edit', 'discover-query'],
     });
 
     render(

static/app/views/dashboards/manage/index.spec.tsx

@@ -226,7 +226,6 @@ describe('Dashboards > Detail', function () {
       ...RouteComponentPropsFixture(),
       organization: {
         ...mockAuthorizedOrg,
-        features: [...FEATURES, 'dashboards-table-view'],
       },
     });
 

static/app/views/dashboards/manage/index.tsx

@@ -255,40 +255,38 @@ function ManageDashboards() {
   function renderActions() {
     const activeSort = getActiveSort();
     return (
-      <StyledActions listView={organization.features.includes('dashboards-table-view')}>
+      <StyledActions>
         <SearchBar
           defaultQuery=""
           query={getQuery()}
           placeholder={t('Search Dashboards')}
           onSearch={query => handleSearch(query)}
         />
-        <Feature features={'organizations:dashboards-table-view'}>
-          <SegmentedControl<DashboardsLayout>
-            onChange={newValue => {
-              setDashboardsLayout(newValue);
-              trackAnalytics('dashboards_manage.change_view_type', {
-                organization,
-                view_type: newValue,
-              });
-            }}
-            size="md"
-            value={dashboardsLayout}
-            aria-label={t('Layout Control')}
-          >
-            <SegmentedControl.Item
-              key="grid"
-              textValue="grid"
-              aria-label={t('Grid View')}
-              icon={<IconGrid />}
-            />
-            <SegmentedControl.Item
-              key="list"
-              textValue="list"
-              aria-label={t('List View')}
-              icon={<IconList />}
-            />
-          </SegmentedControl>
-        </Feature>
+        <SegmentedControl<DashboardsLayout>
+          onChange={newValue => {
+            setDashboardsLayout(newValue);
+            trackAnalytics('dashboards_manage.change_view_type', {
+              organization,
+              view_type: newValue,
+            });
+          }}
+          size="md"
+          value={dashboardsLayout}
+          aria-label={t('Layout Control')}
+        >
+          <SegmentedControl.Item
+            key="grid"
+            textValue="grid"
+            aria-label={t('Grid View')}
+            icon={<IconGrid />}
+          />
+          <SegmentedControl.Item
+            key="list"
+            textValue="list"
+            aria-label={t('List View')}
+            icon={<IconList />}
+          />
+        </SegmentedControl>
         <CompactSelect
           triggerProps={{prefix: t('Sort By')}}
           value={activeSort!.value}
@@ -506,10 +504,9 @@ function ManageDashboards() {
   );
 }
 
-const StyledActions = styled('div')<{listView: boolean}>`
+const StyledActions = styled('div')`
   display: grid;
-  grid-template-columns: ${p =>
-    p.listView ? 'auto max-content max-content' : 'auto max-content'};
+  grid-template-columns: auto max-content max-content;
   gap: ${space(2)};
   margin-bottom: ${space(2)};