Skip to content

Commit 984ff71

Browse files
authored
fix(agent-insights): Invisible icons in span details (#94173)
Some icons inside the span details were invisible as they are styled with css variables which were not available. This PR exports those variable definitions and adds them in relevant places. - closes [TET-702: Invisible icons in span details](https://linear.app/getsentry/issue/TET-702/invisible-icons-in-span-details)
1 parent 3e2fd08 commit 984ff71

File tree

3 files changed

+19
-13
lines changed

3 files changed

+19
-13
lines changed

static/app/views/performance/newTraceDetails/traceDrawer/details/styles.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ import {
7474
useTraceState,
7575
useTraceStateDispatch,
7676
} from 'sentry/views/performance/newTraceDetails/traceState/traceStateProvider';
77+
import {traceGridCssVariables} from 'sentry/views/performance/newTraceDetails/traceWaterfallStyles';
7778

7879
import type {KeyValueActionParams, TraceDrawerActionKind} from './utils';
7980
import {getTraceKeyValueActions, TraceDrawerActionValueKind} from './utils';
@@ -91,6 +92,7 @@ const BodyContainer = styled('div')`
9192
`;
9293

9394
const DetailContainer = styled('div')`
95+
${traceGridCssVariables}
9496
height: 100%;
9597
overflow: hidden;
9698
padding: ${space(1)} ${space(2)};
@@ -1281,7 +1283,7 @@ const MultilineTextLabel = styled('div')`
12811283
margin-bottom: ${space(1)};
12821284
`;
12831285

1284-
const TraceDrawerComponents = {
1286+
export const TraceDrawerComponents = {
12851287
DetailContainer,
12861288
BodyContainer,
12871289
FlexBox,
@@ -1316,5 +1318,3 @@ const TraceDrawerComponents = {
13161318
MultilineJSON,
13171319
MultilineTextLabel,
13181320
};
1319-
1320-
export {TraceDrawerComponents};

static/app/views/performance/newTraceDetails/traceWaterfall.tsx

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ import {isTraceItemDetailsResponse} from 'sentry/views/performance/newTraceDetai
4040
import {TraceLinkNavigationButton} from 'sentry/views/performance/newTraceDetails/traceLinksNavigation/traceLinkNavigationButton';
4141
import {TraceTree} from 'sentry/views/performance/newTraceDetails/traceModels/traceTree';
4242
import {TraceOpenInExploreButton} from 'sentry/views/performance/newTraceDetails/traceOpenInExploreButton';
43+
import {traceGridCssVariables} from 'sentry/views/performance/newTraceDetails/traceWaterfallStyles';
4344
import {useDividerResizeSync} from 'sentry/views/performance/newTraceDetails/useDividerResizeSync';
4445
import {useIsEAPTraceEnabled} from 'sentry/views/performance/newTraceDetails/useIsEAPTraceEnabled';
4546
import {useTraceSpaceListeners} from 'sentry/views/performance/newTraceDetails/useTraceSpaceListeners';
@@ -842,16 +843,7 @@ const TraceLinksNavigationContainer = styled('div')`
842843
export const TraceGrid = styled('div')<{
843844
layout: 'drawer bottom' | 'drawer left' | 'drawer right';
844845
}>`
845-
--info: ${p => p.theme.purple400};
846-
--warning: ${p => p.theme.yellow300};
847-
--debug: ${p => p.theme.blue300};
848-
--error: ${p => p.theme.error};
849-
--fatal: ${p => p.theme.error};
850-
--default: ${p => p.theme.gray300};
851-
--unknown: ${p => p.theme.gray300};
852-
--profile: ${p => p.theme.purple300};
853-
--autogrouped: ${p => p.theme.blue300};
854-
--occurence: ${p => p.theme.blue300};
846+
${traceGridCssVariables}
855847
856848
background-color: ${p => p.theme.background};
857849
border: 1px solid ${p => p.theme.border};
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
import type {Theme} from '@emotion/react';
2+
3+
export const traceGridCssVariables = ({theme}: {theme: Theme}) => `
4+
--info: ${theme.purple400};
5+
--warning: ${theme.yellow300};
6+
--debug: ${theme.blue300};
7+
--error: ${theme.error};
8+
--fatal: ${theme.error};
9+
--default: ${theme.gray300};
10+
--unknown: ${theme.gray300};
11+
--profile: ${theme.purple300};
12+
--autogrouped: ${theme.blue300};
13+
--occurence: ${theme.blue300};
14+
`;

0 commit comments

Comments
 (0)