Skip to content

Commit 3e2fd08

Browse files
authored
fix(symbols): add windows android and ios by default on gaming (#94258)
1 parent 79c52a8 commit 3e2fd08

File tree

2 files changed

+14
-6
lines changed

2 files changed

+14
-6
lines changed

src/sentry/api/helpers/default_symbol_sources.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
DEFAULT_SYMBOL_SOURCES = {
55
"electron": ["ios", "microsoft", "electron"],
66
"javascript-electron": ["ios", "microsoft", "electron"],
7-
"unity": ["unity", "nvidia", "ubuntu"],
8-
"unreal": ["nvidia", "ubuntu"],
9-
"godot": ["nvidia", "ubuntu"],
7+
"unity": ["ios", "microsoft", "android", "nuget", "unity", "nvidia", "ubuntu"],
8+
"unreal": ["ios", "microsoft", "android", "nvidia", "ubuntu"],
9+
"godot": ["ios", "microsoft", "android", "nuget", "nvidia", "ubuntu"],
1010
}
1111

1212

tests/sentry/api/endpoints/test_team_projects.py

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,15 @@ def test_builtin_symbol_sources_unity(self):
385385
symbol_sources = ProjectOption.objects.get_value(
386386
project=unity_project, key="sentry:builtin_symbol_sources"
387387
)
388-
assert symbol_sources == ["unity", "nvidia", "ubuntu"]
388+
assert symbol_sources == [
389+
"ios",
390+
"microsoft",
391+
"android",
392+
"nuget",
393+
"unity",
394+
"nvidia",
395+
"ubuntu",
396+
]
389397

390398
def test_builtin_symbol_sources_unreal(self):
391399
"""
@@ -406,7 +414,7 @@ def test_builtin_symbol_sources_unreal(self):
406414
symbol_sources = ProjectOption.objects.get_value(
407415
project=unreal_project, key="sentry:builtin_symbol_sources"
408416
)
409-
assert symbol_sources == ["nvidia", "ubuntu"]
417+
assert symbol_sources == ["ios", "microsoft", "android", "nvidia", "ubuntu"]
410418

411419
def test_builtin_symbol_sources_godot(self):
412420
"""
@@ -427,7 +435,7 @@ def test_builtin_symbol_sources_godot(self):
427435
symbol_sources = ProjectOption.objects.get_value(
428436
project=godot_project, key="sentry:builtin_symbol_sources"
429437
)
430-
assert symbol_sources == ["nvidia", "ubuntu"]
438+
assert symbol_sources == ["ios", "microsoft", "android", "nuget", "nvidia", "ubuntu"]
431439

432440
@patch("sentry.api.endpoints.team_projects.TeamProjectsEndpoint.create_audit_entry")
433441
def test_create_project_with_origin(self, create_audit_entry):

0 commit comments

Comments
 (0)