chore(issues): Opt codeowners tasks into stronger typing (#94576)

Author: mrduncan

pyproject.toml

@@ -381,6 +381,7 @@ module = [
     "sentry.stacktraces.platform",
     "sentry.status_checks.*",
     "sentry.tasks.beacon",
+    "sentry.tasks.codeowners.*",
     "sentry.tasks.commit_context",
     "sentry.tasks.embeddings_grouping.backfill_seer_grouping_records_for_project",
     "sentry.tasks.on_demand_metrics",
@@ -537,6 +538,7 @@ module = [
     "tests.sentry.security.*",
     "tests.sentry.snuba.metrics.test_metrics_query_layer.*",
     "tests.sentry.tasks.integrations.*",
+    "tests.sentry.tasks.test_code_owners",
     "tests.sentry.tasks.test_on_demand_metrics",
     "tests.sentry.types.*",
     "tests.sentry.types.test_actor",

src/sentry/tasks/codeowners/code_owners_auto_sync.py

@@ -1,3 +1,5 @@
+from typing import Any
+
 from rest_framework.exceptions import NotFound
 
 from sentry.integrations.models.repository_project_path_config import RepositoryProjectPathConfig
@@ -29,7 +31,7 @@
     ),
 )
 @retry(on=(Commit.DoesNotExist,))
-def code_owners_auto_sync(commit_id: int, **kwargs):
+def code_owners_auto_sync(commit_id: int, **kwargs: Any) -> None:
     from django.db.models import BooleanField, Case, Exists, OuterRef, Subquery, When
 
     from sentry.integrations.api.endpoints.organization_code_mapping_codeowners import (

tests/sentry/tasks/test_code_owners.py

@@ -1,5 +1,5 @@
 from datetime import datetime, timezone
-from unittest.mock import patch
+from unittest.mock import MagicMock, patch
 
 from sentry.integrations.models.external_actor import ExternalActor
 from sentry.models.commit import Commit
@@ -18,7 +18,7 @@
 
 
 class CodeOwnersTest(TestCase):
-    def setUp(self):
+    def setUp(self) -> None:
         self.login_as(user=self.user)
 
         self.team = self.create_team(
@@ -49,7 +49,7 @@ def setUp(self):
             self.project, self.code_mapping, raw=self.data["raw"]
         )
 
-    def test_simple(self):
+    def test_simple(self) -> None:
         with self.tasks() and self.feature({"organizations:integrations-codeowners": True}):
             # new external team mapping
             self.external_team = self.create_external_team(integration=self.integration)
@@ -87,7 +87,9 @@ def test_simple(self):
         "sentry.integrations.github.integration.GitHubIntegration.get_codeowner_file",
         return_value=LATEST_GITHUB_CODEOWNERS,
     )
-    def test_codeowners_auto_sync_successful(self, mock_get_codeowner_file, mock_timezone_now):
+    def test_codeowners_auto_sync_successful(
+        self, mock_get_codeowner_file: MagicMock, mock_timezone_now: MagicMock
+    ) -> None:
         with self.tasks() and self.feature({"organizations:integrations-codeowners": True}):
             self.create_external_team()
             self.create_external_user(external_name="@NisanthanNanthakumar")
@@ -134,10 +136,9 @@ def test_codeowners_auto_sync_successful(self, mock_get_codeowner_file, mock_tim
     @patch("sentry.notifications.notifications.codeowners_auto_sync.AutoSyncNotification.send")
     def test_codeowners_auto_sync_failed_to_fetch_file(
         self,
-        mock_send_email,
-        mock_get_codeowner_file,
-    ):
-
+        mock_send_email: MagicMock,
+        mock_get_codeowner_file: MagicMock,
+    ) -> None:
         with self.tasks() and self.feature({"organizations:integrations-codeowners": True}):
             commit = Commit.objects.create(
                 repository_id=self.repo.id,