Skip to content

Commit 2ab4ec1

Browse files
authored
chore(aci): Move metric detector form to folder (#94575)
since we have uptime and cron forms. This adds a folder for metric forms
1 parent c993e11 commit 2ab4ec1

File tree

14 files changed

+24
-21
lines changed

14 files changed

+24
-21
lines changed

static/app/components/workflowEngine/form/control/priorityControl.spec.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {DetectorPriorityLevel} from 'sentry/types/workflowEngine/dataConditions'
77
import {
88
DEFAULT_THRESHOLD_METRIC_FORM_DATA,
99
METRIC_DETECTOR_FORM_FIELDS,
10-
} from 'sentry/views/detectors/components/forms/metricFormData';
10+
} from 'sentry/views/detectors/components/forms/metric/metricFormData';
1111

1212
describe('PriorityControl', function () {
1313
it('renders children', async function () {

static/app/components/workflowEngine/form/control/priorityControl.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import {
1919
import {
2020
METRIC_DETECTOR_FORM_FIELDS,
2121
useMetricDetectorFormField,
22-
} from 'sentry/views/detectors/components/forms/metricFormData';
22+
} from 'sentry/views/detectors/components/forms/metric/metricFormData';
2323
import {useDetectorThresholdSuffix} from 'sentry/views/detectors/components/forms/useDetectorThresholdSuffix';
2424

2525
const priorities = [

static/app/views/detectors/components/forms/assigneeField.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import styled from '@emotion/styled';
44
import SentryMemberTeamSelectorField from 'sentry/components/forms/fields/sentryMemberTeamSelectorField';
55
import {t} from 'sentry/locale';
66
import useProjects from 'sentry/utils/useProjects';
7-
import {METRIC_DETECTOR_FORM_FIELDS} from 'sentry/views/detectors/components/forms/metricFormData';
7+
import {METRIC_DETECTOR_FORM_FIELDS} from 'sentry/views/detectors/components/forms/metric/metricFormData';
88

99
type AssigneeFieldProps = {
1010
projectId: string;

static/app/views/detectors/components/forms/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import type {DetectorType} from 'sentry/types/workflowEngine/detectors';
22
import {unreachable} from 'sentry/utils/unreachable';
33
import {CronDetectorForm} from 'sentry/views/detectors/components/forms/cron';
4-
import {MetricDetectorForm} from 'sentry/views/detectors/components/forms/metric';
4+
import {MetricDetectorForm} from 'sentry/views/detectors/components/forms/metric/metric';
55
import {UptimeDetectorForm} from 'sentry/views/detectors/components/forms/uptime';
66

77
type DetectorFormProps = {

static/app/views/detectors/components/forms/getDatasetConfig.tsx renamed to static/app/views/detectors/components/forms/metric/getDatasetConfig.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import {ErrorsConfig} from 'sentry/views/dashboards/datasetConfig/errors';
22
import {ReleasesConfig} from 'sentry/views/dashboards/datasetConfig/releases';
33
import {SpansConfig} from 'sentry/views/dashboards/datasetConfig/spans';
44
import {TransactionsConfig} from 'sentry/views/dashboards/datasetConfig/transactions';
5-
import {DetectorDataset} from 'sentry/views/detectors/components/forms/metricFormData';
5+
import {DetectorDataset} from 'sentry/views/detectors/components/forms/metric/metricFormData';
66

77
/**
88
* @returns a configuration object used to display the aggregate function selector and the search bar

static/app/views/detectors/components/forms/metric.tsx renamed to static/app/views/detectors/components/forms/metric/metric.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,16 +26,16 @@ import {
2626
AlertRuleThresholdType,
2727
} from 'sentry/views/alerts/rules/metric/types';
2828
import {AssigneeField} from 'sentry/views/detectors/components/forms/assigneeField';
29-
import {getDatasetConfig} from 'sentry/views/detectors/components/forms/getDatasetConfig';
30-
import type {MetricDetectorFormData} from 'sentry/views/detectors/components/forms/metricFormData';
29+
import {getDatasetConfig} from 'sentry/views/detectors/components/forms/metric/getDatasetConfig';
30+
import type {MetricDetectorFormData} from 'sentry/views/detectors/components/forms/metric/metricFormData';
3131
import {
3232
DetectorDataset,
3333
METRIC_DETECTOR_FORM_FIELDS,
3434
useMetricDetectorFormField,
35-
} from 'sentry/views/detectors/components/forms/metricFormData';
35+
} from 'sentry/views/detectors/components/forms/metric/metricFormData';
36+
import {Visualize} from 'sentry/views/detectors/components/forms/metric/visualize';
3637
import {SectionLabel} from 'sentry/views/detectors/components/forms/sectionLabel';
3738
import {useDetectorThresholdSuffix} from 'sentry/views/detectors/components/forms/useDetectorThresholdSuffix';
38-
import {Visualize} from 'sentry/views/detectors/components/forms/visualize';
3939
import {getResolutionDescription} from 'sentry/views/detectors/utils/getDetectorResolutionDescription';
4040
import {TraceItemAttributeProvider} from 'sentry/views/explore/contexts/traceItemAttributeContext';
4141
import {TraceItemDataset} from 'sentry/views/explore/types';

static/app/views/detectors/components/forms/queryFilterBuilder.tsx renamed to static/app/views/detectors/components/forms/metric/queryFilterBuilder.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ import {t} from 'sentry/locale';
88
import {space} from 'sentry/styles/space';
99
import type {PageFilters} from 'sentry/types/core';
1010
import type {WidgetQuery} from 'sentry/views/dashboards/types';
11-
import {getDatasetConfig} from 'sentry/views/detectors/components/forms/getDatasetConfig';
11+
import {getDatasetConfig} from 'sentry/views/detectors/components/forms/metric/getDatasetConfig';
1212
import {
1313
METRIC_DETECTOR_FORM_FIELDS,
1414
useMetricDetectorFormField,
15-
} from 'sentry/views/detectors/components/forms/metricFormData';
15+
} from 'sentry/views/detectors/components/forms/metric/metricFormData';
1616
import {
1717
SectionLabel,
1818
SectionLabelSecondary,

static/app/views/detectors/components/forms/visualize.tsx renamed to static/app/views/detectors/components/forms/metric/visualize.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,14 @@ import {ALLOWED_EXPLORE_VISUALIZE_AGGREGATES, prettifyTagKey} from 'sentry/utils
1717
import {unreachable} from 'sentry/utils/unreachable';
1818
import useOrganization from 'sentry/utils/useOrganization';
1919
import useTags from 'sentry/utils/useTags';
20-
import {useCustomMeasurements} from 'sentry/views/detectors/components/forms/customMeasurements';
21-
import {getDatasetConfig} from 'sentry/views/detectors/components/forms/getDatasetConfig';
20+
import {useCustomMeasurements} from 'sentry/views/detectors/components/forms/metric/customMeasurements';
21+
import {getDatasetConfig} from 'sentry/views/detectors/components/forms/metric/getDatasetConfig';
2222
import {
2323
DetectorDataset,
2424
METRIC_DETECTOR_FORM_FIELDS,
2525
useMetricDetectorFormField,
26-
} from 'sentry/views/detectors/components/forms/metricFormData';
27-
import {DetectorQueryFilterBuilder} from 'sentry/views/detectors/components/forms/queryFilterBuilder';
26+
} from 'sentry/views/detectors/components/forms/metric/metricFormData';
27+
import {DetectorQueryFilterBuilder} from 'sentry/views/detectors/components/forms/metric/queryFilterBuilder';
2828
import {SectionLabel} from 'sentry/views/detectors/components/forms/sectionLabel';
2929
import type {FieldValue} from 'sentry/views/discover/table/types';
3030
import {FieldValueKind} from 'sentry/views/discover/table/types';

0 commit comments

Comments
 (0)