feat(aci): Add custom datasets for detectors (#94800)

We were using discover datasets for metric detectors which helped us
quickly demo how we can reuse their configurations to populate the
dropdowns for metric aggregate options.

Some differences between widgets and detectors
- Their functions expect a WidgetQuery object
- We don't really use the pageFiltersStore as our source of truth, all
of their stuff does and hooks/contexts directly read from the store
- We can avoid making contexts that only wrap react query
- We might have a different set of allowed functions and tags or default
queries
- Transforming to a graph series for us is different and needs to be
exported for chartcuterie

Author: scttcper

static/app/views/detectors/components/forms/metric/getDatasetConfig.tsx

@@ -23,14 +23,12 @@ import {
 import type {Detector} from 'sentry/types/workflowEngine/detectors';
 import {generateFieldAsString} from 'sentry/utils/discover/fields';
 import useOrganization from 'sentry/utils/useOrganization';
-import useProjects from 'sentry/utils/useProjects';
 import {
   AlertRuleSensitivity,
   AlertRuleThresholdType,
 } from 'sentry/views/alerts/rules/metric/types';
 import {AssigneeField} from 'sentry/views/detectors/components/forms/assigneeField';
 import {EditDetectorLayout} from 'sentry/views/detectors/components/forms/editDetectorLayout';
-import {getDatasetConfig} from 'sentry/views/detectors/components/forms/metric/getDatasetConfig';
 import type {MetricDetectorFormData} from 'sentry/views/detectors/components/forms/metric/metricFormData';
 import {
   DetectorDataset,
@@ -40,51 +38,19 @@ import {
 import {Visualize} from 'sentry/views/detectors/components/forms/metric/visualize';
 import {NewDetectorLayout} from 'sentry/views/detectors/components/forms/newDetectorLayout';
 import {SectionLabel} from 'sentry/views/detectors/components/forms/sectionLabel';
+import {getDatasetConfig} from 'sentry/views/detectors/datasetConfig/getDatasetConfig';
 import {getResolutionDescription} from 'sentry/views/detectors/utils/getDetectorResolutionDescription';
 import {getStaticDetectorThresholdSuffix} from 'sentry/views/detectors/utils/metricDetectorSuffix';
-import {TraceItemAttributeProvider} from 'sentry/views/explore/contexts/traceItemAttributeContext';
-import {TraceItemDataset} from 'sentry/views/explore/types';
-
-function MetricDetectorFormContext({children}: {children: React.ReactNode}) {
-  const projectId = useMetricDetectorFormField(METRIC_DETECTOR_FORM_FIELDS.projectId);
-  const dataset = useMetricDetectorFormField(METRIC_DETECTOR_FORM_FIELDS.dataset);
-  const {projects} = useProjects();
-
-  const traceItemProjects = useMemo(() => {
-    const project = projects.find(p => p.id === projectId);
-    if (!project) {
-      return undefined;
-    }
-    return [project];
-  }, [projectId, projects]);
-
-  let traceItemType = TraceItemDataset.SPANS;
-  if (dataset === DetectorDataset.LOGS) {
-    traceItemType = TraceItemDataset.LOGS;
-  }
-
-  return (
-    <TraceItemAttributeProvider
-      traceItemType={traceItemType}
-      projects={traceItemProjects}
-      enabled
-    >
-      {children}
-    </TraceItemAttributeProvider>
-  );
-}
 
 function MetricDetectorForm() {
   return (
-    <MetricDetectorFormContext>
-      <FormStack>
-        <DetectSection />
-        <PrioritizeSection />
-        <ResolveSection />
-        <AssignSection />
-        <AutomateSection />
-      </FormStack>
-    </MetricDetectorFormContext>
+    <FormStack>
+      <DetectSection />
+      <PrioritizeSection />
+      <ResolveSection />
+      <AssignSection />
+      <AutomateSection />
+    </FormStack>
   );
 }
 

static/app/views/detectors/components/forms/metric/metric.tsx

@@ -6,23 +6,41 @@ import {Tooltip} from 'sentry/components/core/tooltip';
 import FormContext from 'sentry/components/forms/formContext';
 import {t} from 'sentry/locale';
 import {space} from 'sentry/styles/space';
-import type {PageFilters} from 'sentry/types/core';
-import type {WidgetQuery} from 'sentry/views/dashboards/types';
-import {getDatasetConfig} from 'sentry/views/detectors/components/forms/metric/getDatasetConfig';
+import {DiscoverDatasets} from 'sentry/utils/discover/types';
+import {unreachable} from 'sentry/utils/unreachable';
 import {
+  DetectorDataset,
   METRIC_DETECTOR_FORM_FIELDS,
   useMetricDetectorFormField,
 } from 'sentry/views/detectors/components/forms/metric/metricFormData';
 import {
   SectionLabel,
   SectionLabelSecondary,
 } from 'sentry/views/detectors/components/forms/sectionLabel';
+import {getDatasetConfig} from 'sentry/views/detectors/datasetConfig/getDatasetConfig';
+
+function getDiscoverDataset(dataset: DetectorDataset): DiscoverDatasets {
+  switch (dataset) {
+    case DetectorDataset.ERRORS:
+      return DiscoverDatasets.ERRORS;
+    case DetectorDataset.TRANSACTIONS:
+      return DiscoverDatasets.TRANSACTIONS;
+    case DetectorDataset.SPANS:
+      return DiscoverDatasets.SPANS_EAP;
+    case DetectorDataset.LOGS:
+      return DiscoverDatasets.OURLOGS;
+    case DetectorDataset.RELEASES:
+      return DiscoverDatasets.DISCOVER;
+    default:
+      unreachable(dataset);
+      return DiscoverDatasets.ERRORS;
+  }
+}
 
 export function DetectorQueryFilterBuilder() {
   const currentQuery = useMetricDetectorFormField(METRIC_DETECTOR_FORM_FIELDS.query);
   const dataset = useMetricDetectorFormField(METRIC_DETECTOR_FORM_FIELDS.dataset);
   const projectId = useMetricDetectorFormField(METRIC_DETECTOR_FORM_FIELDS.projectId);
-  const environment = useMetricDetectorFormField(METRIC_DETECTOR_FORM_FIELDS.environment);
   const formContext = useContext(FormContext);
 
   const datasetConfig = useMemo(() => getDatasetConfig(dataset), [dataset]);
@@ -32,33 +50,12 @@ export function DetectorQueryFilterBuilder() {
     formContext.form?.setValue(METRIC_DETECTOR_FORM_FIELDS.query, queryString);
   };
 
-  // Create mock page filters using form data
-  const mockPageFilters = useMemo(
-    (): PageFilters => ({
-      projects: projectId ? [parseInt(projectId, 10)] : [],
-      environments: environment ? [environment] : [],
-      datetime: {
-        start: null,
-        end: null,
-        period: '24h',
-        utc: false,
-      },
-    }),
-    [projectId, environment]
-  );
-
-  // Create a mock widget query for the SearchBar
-  const widgetQuery = useMemo(
-    (): WidgetQuery => ({
-      conditions: currentQuery || '',
-      aggregates: [],
-      columns: [],
-      fieldAliases: [],
-      name: '',
-      orderby: '',
-    }),
-    [currentQuery]
-  );
+  const projectIds = useMemo(() => {
+    if (projectId) {
+      return [Number(projectId)];
+    }
+    return [];
+  }, [projectId]);
 
   return (
     <Flex direction="column" gap={space(0.5)} flex={1}>
@@ -75,14 +72,11 @@ export function DetectorQueryFilterBuilder() {
       </div>
       <QueryFieldRowWrapper>
         <SearchBar
-          pageFilters={mockPageFilters}
-          onClose={(field: string) => {
-            handleQueryChange(field);
-          }}
+          initialQuery={currentQuery}
+          projectIds={projectIds}
+          onClose={handleQueryChange}
           onSearch={handleQueryChange}
-          widgetQuery={widgetQuery}
-          portalTarget={document.body}
-          getFilterWarning={() => null}
+          dataset={getDiscoverDataset(dataset)}
         />
       </QueryFieldRowWrapper>
     </Flex>