fix(trace): Remove spans from meta response (#94983)

- This removes the spans data from the meta response
- To make transistion easier we're just keeping the keys but having them
return empty or 0

Author: wmak

src/sentry/api/endpoints/organization_events_trace.py

@@ -1767,16 +1767,6 @@ def get(self, request: Request, organization: Organization, trace_id: str) -> Ht
             query=f"trace:{trace_id}",
             limit=1,
         )
-        span_meta_query = SpansIndexedQueryBuilder(
-            dataset=Dataset.SpansIndexed,
-            selected_columns=[
-                "count() as span_count",
-            ],
-            params={},
-            snuba_params=snuba_params,
-            query=f"trace:{trace_id}",
-            limit=1,
-        )
         transaction_children_query = SpansIndexedQueryBuilder(
             dataset=Dataset.SpansIndexed,
             selected_columns=[
@@ -1789,35 +1779,19 @@ def get(self, request: Request, organization: Organization, trace_id: str) -> Ht
             query=f"trace:{trace_id}",
             limit=10_000,
         )
-        span_count_query = SpansIndexedQueryBuilder(
-            dataset=Dataset.SpansIndexed,
-            selected_columns=[
-                "span.op",
-                "count()",
-            ],
-            orderby=["-count()"],
-            params={},
-            snuba_params=snuba_params,
-            query=f"trace:{trace_id}",
-            limit=10_000,
-        )
 
         with handle_query_errors():
             results = bulk_snuba_queries(
                 [
                     meta_query.get_snql_query(),
                     transaction_children_query.get_snql_query(),
-                    span_meta_query.get_snql_query(),
-                    span_count_query.get_snql_query(),
                 ],
                 referrer=Referrer.API_TRACE_VIEW_GET_META.value,
                 query_source=query_source,
             )
-            meta_result, children_result, span_meta_result, span_count_result = (
+            meta_result, children_result = (
                 results[0],
                 results[1],
-                results[2],
-                results[3],
             )
             if len(meta_result["data"]) == 0:
                 return Response(status=404)
@@ -1831,21 +1805,21 @@ def get(self, request: Request, organization: Organization, trace_id: str) -> Ht
             self.serialize(
                 meta_result["data"][0],
                 children_result["data"],
-                span_count_result["data"],
-                span_meta_result["data"][0],
             )
         )
 
     def serialize(
-        self, results: Mapping[str, int], child_result: Any, span_result: Any, span_meta_result: Any
+        self,
+        results: Mapping[str, int],
+        child_result: Any,
     ) -> Mapping[str, int | dict[str, int]]:
         return {
             # Values can be null if there's no result
             "projects": results.get("projects") or 0,
             "transactions": results.get("transactions") or 0,
             "errors": results.get("errors") or 0,
             "performance_issues": results.get("performance_issues") or 0,
-            "span_count": span_meta_result.get("span_count") or 0,
+            "span_count": 0,
             "transaction_child_count_map": child_result,
-            "span_count_map": {row["span.op"]: row["count"] for row in span_result},
+            "span_count_map": {},
         }

tests/snuba/api/endpoints/test_organization_events_trace.py

@@ -1708,8 +1708,8 @@ def test_simple(self):
         assert data["transactions"] == 8
         assert data["errors"] == 0
         assert data["performance_issues"] == 2
-        assert data["span_count"] == 19
-        assert data["span_count_map"]["http.server"] == 19
+        assert data["span_count"] == 0
+        assert data["span_count_map"] == {}
 
     def test_no_team(self):
         self.load_trace()
@@ -1725,8 +1725,8 @@ def test_no_team(self):
         assert data["transactions"] == 8
         assert data["errors"] == 0
         assert data["performance_issues"] == 2
-        assert data["span_count"] == 19
-        assert data["span_count_map"]["http.server"] == 19
+        assert data["span_count"] == 0
+        assert data["span_count_map"] == {}
 
     def test_with_errors(self):
         self.load_trace()
@@ -1743,8 +1743,8 @@ def test_with_errors(self):
         assert data["transactions"] == 8
         assert data["errors"] == 3
         assert data["performance_issues"] == 2
-        assert data["span_count"] == 19
-        assert data["span_count_map"]["http.server"] == 19
+        assert data["span_count"] == 0
+        assert data["span_count_map"] == {}
 
     def test_with_default(self):
         self.load_trace()
@@ -1761,6 +1761,6 @@ def test_with_default(self):
         assert data["transactions"] == 8
         assert data["errors"] == 1
         assert data["performance_issues"] == 2
-        assert data["span_count"] == 19
-        assert data["span_count_map"]["http.server"] == 19
+        assert data["span_count"] == 0
+        assert data["span_count_map"] == {}
         assert len(data["transaction_child_count_map"]) == 8