Revert "feat(dashboards): Expose lastVisited through dashboards list API (#95468)"

This reverts commit 4d7a4a1.

Co-authored-by: narsaynorath <22846452+narsaynorath@users.noreply.github.com>

Author: getsentry-bot

src/sentry/api/endpoints/organization_dashboards.py

@@ -254,14 +254,7 @@ def handle_results(results):
                 else:
                     dashboards.append(item)
 
-            serialized.extend(
-                serialize(
-                    dashboards,
-                    request.user,
-                    serializer=list_serializer,
-                    context={"organization": organization},
-                )
-            )
+            serialized.extend(serialize(dashboards, request.user, serializer=list_serializer))
             return serialized
 
         render_pre_built_dashboard = True

src/sentry/api/endpoints/organization_dashboards_starred.py

@@ -62,12 +62,7 @@ def data_fn(offset, limit):
         return self.paginate(
             request=request,
             paginator=GenericOffsetPaginator(data_fn=data_fn),
-            on_results=lambda x: serialize(
-                x,
-                request.user,
-                serializer=DashboardListSerializer(),
-                context={"organization": organization},
-            ),
+            on_results=lambda x: serialize(x, request.user, serializer=DashboardListSerializer()),
             default_per_page=25,
         )
 

src/sentry/api/serializers/models/dashboard.py

@@ -6,7 +6,6 @@
 
 from django.db.models import prefetch_related_objects
 
-from sentry import features
 from sentry.api.serializers import Serializer, register, serialize
 from sentry.models.dashboard import Dashboard, DashboardFavoriteUser
 from sentry.models.dashboard_permissions import DashboardPermissions
@@ -190,7 +189,6 @@ class DashboardListResponse(TypedDict):
     createdBy: UserSerializerResponse
     environment: list[str]
     filters: DashboardFilters
-    lastVisited: str | None
     widgetDisplay: list[str]
     widgetPreview: list[dict[str, str]]
     permissions: DashboardPermissionsResponse | None
@@ -212,7 +210,6 @@ class _Widget(TypedDict):
     projects: list[int]
     environment: list[str]
     filters: DashboardFilters
-    last_visited: str | None
 
 
 class PageFiltersOptional(TypedDict, total=False):
@@ -265,9 +262,8 @@ def get_filters(self, obj: Dashboard) -> tuple[PageFilters, DashboardFilters]:
 
 class DashboardListSerializer(Serializer, DashboardFiltersMixin):
     def get_attrs(self, item_list, user, **kwargs):
-        organization = kwargs.get("context", {}).get("organization")
         item_dict = {i.id: i for i in item_list}
-        prefetch_related_objects(item_list, "projects", "dashboardlastvisited_set__member")
+        prefetch_related_objects(item_list, "projects")
 
         widgets = DashboardWidget.objects.filter(dashboard_id__in=item_dict.keys()).order_by(
             "order"
@@ -290,7 +286,6 @@ def get_attrs(self, item_list, user, **kwargs):
                 "projects": [],
                 "environment": [],
                 "filters": {},
-                "last_visited": None,
             }
         )
         for widget in widgets:
@@ -329,18 +324,6 @@ def get_attrs(self, item_list, user, **kwargs):
             result[dashboard]["permissions"] = serialize(permission)
 
         for dashboard in item_dict.values():
-            if features.has(
-                "organizations:dashboards-starred-reordering",
-                organization,
-                user,
-            ):
-                visit = dashboard.dashboardlastvisited_set.filter(
-                    dashboard=dashboard,
-                    member__user_id=user.id,
-                    member__organization=organization,
-                ).first()
-                result[dashboard]["last_visited"] = visit.last_visited if visit else None
-
             result[dashboard]["created_by"] = serialized_users.get(str(dashboard.created_by_id))
             result[dashboard]["is_favorited"] = dashboard.id in favorited_dashboard_ids
 
@@ -364,7 +347,6 @@ def serialize(self, obj, attrs, user, **kwargs) -> DashboardListResponse:
             "projects": attrs.get("projects", []),
             "environment": attrs.get("environment", []),
             "filters": attrs.get("filters", {}),
-            "lastVisited": attrs.get("last_visited", None),
         }
 
 

src/sentry/apidocs/examples/dashboard_examples.py

@@ -81,7 +81,6 @@
         "id": "1",
         "title": "Dashboard",
         "dateCreated": "2024-06-20T14:38:03.498574Z",
-        "lastVisited": "2024-06-20T14:38:03.498574Z",
         "projects": [1],
         "environment": ["alpha"],
         "filters": {
@@ -122,7 +121,6 @@
         "id": "2",
         "title": "Dashboard",
         "dateCreated": "2024-06-20T14:38:03.498574Z",
-        "lastVisited": "2024-06-20T14:38:03.498574Z",
         "projects": [],
         "environment": ["alpha"],
         "filters": {

tests/sentry/api/endpoints/test_organization_dashboards.py

@@ -5,18 +5,12 @@
 
 from django.urls import reverse
 
-from sentry.models.dashboard import (
-    Dashboard,
-    DashboardFavoriteUser,
-    DashboardLastVisited,
-    DashboardTombstone,
-)
+from sentry.models.dashboard import Dashboard, DashboardFavoriteUser, DashboardTombstone
 from sentry.models.dashboard_widget import (
     DashboardWidget,
     DashboardWidgetDisplayTypes,
     DashboardWidgetTypes,
 )
-from sentry.models.organizationmember import OrganizationMember
 from sentry.testutils.cases import OrganizationDashboardWidgetTestCase
 from sentry.testutils.helpers.datetime import before_now
 
@@ -787,45 +781,6 @@ def test_get_with_filters(self):
         assert response.data[0].get("environment") == ["alpha"]
         assert response.data[0].get("filters") == {"release": ["v1"]}
 
-    def test_get_with_last_visited(self):
-        # Clean up existing dashboards setup for this test.
-        Dashboard.objects.all().delete()
-
-        Dashboard.objects.create(
-            title="Dashboard without last visited",
-            organization=self.organization,
-            created_by_id=self.user.id,
-        )
-        dashboard_2 = Dashboard.objects.create(
-            title="Dashboard with last visited",
-            organization=self.organization,
-            created_by_id=self.user.id,
-        )
-        now = before_now(minutes=0)
-        DashboardLastVisited.objects.create(
-            dashboard=dashboard_2,
-            member=OrganizationMember.objects.get(
-                organization=self.organization, user_id=self.user.id
-            ),
-            last_visited=now,
-        )
-
-        with self.feature("organizations:dashboards-starred-reordering"):
-            response = self.client.get(self.url, data={"sort": "recentlyViewed"})
-        assert response.status_code == 200, response.content
-        assert len(response.data) == 3
-
-        titles = [row["title"] for row in response.data]
-        assert titles == [
-            "General",
-            "Dashboard with last visited",
-            "Dashboard without last visited",
-        ]
-
-        # Only "Dashboard with last visited" has a last visited timestamp.
-        visited_at = [row.get("lastVisited") for row in response.data]
-        assert visited_at == [None, now, None]
-
     def test_post(self):
         response = self.do_request("post", self.url, data={"title": "Dashboard from Post"})
         assert response.status_code == 201