Skip to content

Commit 1877290

Browse files
authored
ref(replay): Centralize ReplayTable cell rendering into replayTableColumns (#94552)
The places where these cells get rendered are: - Replay List (`/explore/replays/`) - Issue -> Replays (`/issues/<issue_id>/replays/`) - Transaction Summary -> Replays (`/insights/frontend/summary/replays/?transaction=<transaction_name>`) I checked each, and things look good. - Sorting only on the Replay List page - Dropdowns appear only on the Replay List page - Padding is reasonable everywhere (including deleted replays on the list page) | Desc | Img | | --- | --- | | Replay List | <img width="1252" alt="SCR-20250627-jrda" src="https://github.com/user-attachments/assets/1bd73f07-ace5-43ac-9289-d7244838f994" /> | Replay List (deleted item | <img width="1267" alt="SCR-20250627-jsmo" src="https://github.com/user-attachments/assets/cb238677-5eac-4ebe-b191-9ced4b708394" /> | Issues -> Replays | <img width="934" alt="SCR-20250627-jrgk" src="https://github.com/user-attachments/assets/c6ad93c5-987d-40bc-aa7a-d42437da173e" /> | Transaction -> Replays | <img width="1282" alt="SCR-20250627-jqyh" src="https://github.com/user-attachments/assets/e72187c8-a06b-4e78-be88-277739d18a16" />
1 parent 7f48563 commit 1877290

File tree

6 files changed

+541
-467
lines changed

6 files changed

+541
-467
lines changed

static/app/components/events/eventReplay/replayPreviewPlayer.tsx

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,9 @@ import TimeAndScrubberGrid from 'sentry/components/replays/timeAndScrubberGrid';
1717
import {IconNext, IconPrevious} from 'sentry/icons';
1818
import {t} from 'sentry/locale';
1919
import {space} from 'sentry/styles/space';
20-
import EventView from 'sentry/utils/discover/eventView';
2120
import getRouteStringFromRoutes from 'sentry/utils/getRouteStringFromRoutes';
2221
import {TabKey} from 'sentry/utils/replays/hooks/useActiveReplayTab';
2322
import useMarkReplayViewed from 'sentry/utils/replays/hooks/useMarkReplayViewed';
24-
import {useLocation} from 'sentry/utils/useLocation';
2523
import useOrganization from 'sentry/utils/useOrganization';
2624
import {useParams} from 'sentry/utils/useParams';
2725
import {useRoutes} from 'sentry/utils/useRoutes';
@@ -56,12 +54,10 @@ export default function ReplayPreviewPlayer({
5654
showNextAndPrevious?: boolean;
5755
}) {
5856
const routes = useRoutes();
59-
const location = useLocation();
6057
const organization = useOrganization();
6158
const [isSidebarOpen, setIsSidebarOpen] = useState(true);
6259
const {replay, currentTime, isFetching, isFinished, isPlaying, isVideoReplay} =
6360
useReplayContext();
64-
const eventView = EventView.fromLocation(location);
6561

6662
const fullscreenRef = useRef<HTMLDivElement | null>(null);
6763
const {toggle: toggleFullscreen} = useFullscreen({
@@ -98,9 +94,7 @@ export default function ReplayPreviewPlayer({
9894
)}
9995
<HeaderWrapper>
10096
<StyledReplayCell
101-
eventView={eventView}
10297
key="session"
103-
referrer="issue-details-replay-header"
10498
replay={replayRecord as ReplayListRecord}
10599
rowIndex={0}
106100
/>

0 commit comments

Comments
 (0)