ref: Handle edge cases in formatting step more gracefully #687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
requested review from
a team,
andreiborza,
onurtemizkan and
stephanie-anderson
and removed request for
a team and
stephanie-anderson
Lms24
commented
Oct 15, 2024
Comment on lines
+692
to
+712
| const packageJson = await getPackageDotJson(); | ||
| const prettierInstalled = hasPackageInstalled('prettier', packageJson); | ||
|
|
||
| Sentry.setTag('prettier-installed', prettierInstalled); | ||
|
|
||
| if (!prettierInstalled) { | ||
| return; | ||
| } | ||
|
|
||
| // prompt the user if they want to run prettier | ||
| const shouldRunPrettier = await abortIfCancelled( | ||
| clack.confirm({ | ||
| message: | ||
| 'Looks like you have Prettier in your project. Do you want to run it on your files?', | ||
| }), | ||
| ); | ||
|
|
||
| if (!shouldRunPrettier) { | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
No behavior changes here, just made a small refactoring to avoid the double-nested if block
Lms24
commented
Oct 15, 2024
| } catch (e) { | ||
| prettierSpinner.stop('Prettier failed to run.'); | ||
| clack.log.error( | ||
| clack.log.warn( |
There was a problem hiding this comment.
I think it's ok to downgrade this to a warning because it won't (shouldn't) cause the wizard to error. It'll just continue with the next step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed while running a repro sveltekit app in a new directory where I didn't yet initialize git that the auto-format step wasn't behaving correctly. For some reason, the child process promise when running
npx prettier ...never resolved and I had to quit the wizard.This PR makes a couple of changes to the prettier formatting step: