test: Add Next.js E2E tests #684
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,3 +33,5 @@ plugins | |
| .vscode/launch.json | ||
|
|
||
| package-lock.json | ||
|
|
||
| .env | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| ### SENTRY TEST AUTH TOKEN ### | ||
| SENTRY_TEST_AUTH_TOKEN="TEST_AUTH_TOKEN" | ||
|
|
||
| ### SENTRY TEST DSN ### | ||
| SENTRY_TEST_DSN="TEST_DSN" | ||
|
|
||
| ### SENTRY TEST ORG ### | ||
| SENTRY_TEST_ORG="TEST_ORG" | ||
|
|
||
| ### SENTRY TEST PROJECT ### | ||
| SENTRY_TEST_PROJECT="TEST_PROJECT" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # See https://help.github.com/articles/ignoring-files/ for more about ignoring files. | ||
|
|
||
| # dependencies | ||
| /node_modules | ||
| /.pnp | ||
| .pnp.js | ||
| .yarn/install-state.gz | ||
|
|
||
| # testing | ||
| /coverage | ||
|
|
||
| # next.js | ||
| /.next/ | ||
| /out/ | ||
|
|
||
| # production | ||
| /build | ||
|
|
||
| # misc | ||
| .DS_Store | ||
| *.pem | ||
|
|
||
| # debug | ||
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
|
|
||
| # local env files | ||
| .env*.local | ||
|
|
||
| # vercel | ||
| .vercel | ||
|
|
||
| # typescript | ||
| *.tsbuildinfo | ||
| next-env.d.ts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| /// <reference types="next" /> | ||
| /// <reference types="next/image-types/global" /> | ||
|
|
||
| // NOTE: This file should not be edited | ||
| // see https://nextjs.org/docs/app/building-your-application/configuring/typescript for more information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| /** @type {import('next').NextConfig} */ | ||
| const nextConfig = {}; | ||
|
|
||
| export default nextConfig; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| { | ||
| "name": "nextjs-test-app", | ||
| "version": "0.1.0", | ||
| "private": true, | ||
| "scripts": { | ||
| "dev": "next dev", | ||
| "build": "next build", | ||
| "start": "next start", | ||
| "lint": "next lint" | ||
| }, | ||
| "dependencies": { | ||
| "react": "^18", | ||
| "react-dom": "^18", | ||
| "next": "14.2.14" | ||
| }, | ||
| "devDependencies": { | ||
| "typescript": "^5", | ||
| "@types/node": "^20", | ||
| "@types/react": "^18", | ||
| "@types/react-dom": "^18" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| :root { | ||
|
||
| --background: #ffffff; | ||
| --foreground: #171717; | ||
| } | ||
|
|
||
| @media (prefers-color-scheme: dark) { | ||
| :root { | ||
| --background: #0a0a0a; | ||
| --foreground: #ededed; | ||
| } | ||
| } | ||
|
|
||
| html, | ||
| body { | ||
| max-width: 100vw; | ||
| overflow-x: hidden; | ||
| } | ||
|
|
||
| body { | ||
| color: var(--foreground); | ||
| background: var(--background); | ||
| font-family: Arial, Helvetica, sans-serif; | ||
| -webkit-font-smoothing: antialiased; | ||
| -moz-osx-font-smoothing: grayscale; | ||
| } | ||
|
|
||
| * { | ||
| box-sizing: border-box; | ||
| padding: 0; | ||
| margin: 0; | ||
| } | ||
|
|
||
| a { | ||
| color: inherit; | ||
| text-decoration: none; | ||
| } | ||
|
|
||
| @media (prefers-color-scheme: dark) { | ||
| html { | ||
| color-scheme: dark; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import type { Metadata } from "next"; | ||
| import "./globals.css"; | ||
|
|
||
| export const metadata: Metadata = { | ||
| title: "Create Next App", | ||
| description: "Generated by create next app", | ||
| }; | ||
|
|
||
| export default function RootLayout({ | ||
| children, | ||
| }: Readonly<{ | ||
| children: React.ReactNode; | ||
| }>) { | ||
| return ( | ||
| <html lang="en"> | ||
| <body> | ||
| {children} | ||
| </body> | ||
| </html> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,165 @@ | ||
| .page { | ||
| --gray-rgb: 0, 0, 0; | ||
| --gray-alpha-200: rgba(var(--gray-rgb), 0.08); | ||
| --gray-alpha-100: rgba(var(--gray-rgb), 0.05); | ||
|
|
||
| --button-primary-hover: #383838; | ||
| --button-secondary-hover: #f2f2f2; | ||
|
|
||
| display: grid; | ||
| grid-template-rows: 20px 1fr 20px; | ||
| align-items: center; | ||
| justify-items: center; | ||
| min-height: 100svh; | ||
| padding: 80px; | ||
| gap: 64px; | ||
| font-family: var(--font-geist-sans); | ||
| } | ||
|
|
||
| @media (prefers-color-scheme: dark) { | ||
| .page { | ||
| --gray-rgb: 255, 255, 255; | ||
| --gray-alpha-200: rgba(var(--gray-rgb), 0.145); | ||
| --gray-alpha-100: rgba(var(--gray-rgb), 0.06); | ||
|
|
||
| --button-primary-hover: #ccc; | ||
| --button-secondary-hover: #1a1a1a; | ||
| } | ||
| } | ||
|
|
||
| .main { | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: 32px; | ||
| grid-row-start: 2; | ||
| } | ||
|
|
||
| .main ol { | ||
| font-family: var(--font-geist-mono); | ||
| padding-left: 0; | ||
| margin: 0; | ||
| font-size: 14px; | ||
| line-height: 24px; | ||
| letter-spacing: -0.01em; | ||
| list-style-position: inside; | ||
| } | ||
|
|
||
| .main li:not(:last-of-type) { | ||
| margin-bottom: 8px; | ||
| } | ||
|
|
||
| .main code { | ||
| font-family: inherit; | ||
| background: var(--gray-alpha-100); | ||
| padding: 2px 4px; | ||
| border-radius: 4px; | ||
| font-weight: 600; | ||
| } | ||
|
|
||
| .ctas { | ||
| display: flex; | ||
| gap: 16px; | ||
| } | ||
|
|
||
| .ctas a { | ||
| appearance: none; | ||
| border-radius: 128px; | ||
| height: 48px; | ||
| padding: 0 20px; | ||
| border: none; | ||
| border: 1px solid transparent; | ||
| transition: background 0.2s, color 0.2s, border-color 0.2s; | ||
| cursor: pointer; | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| font-size: 16px; | ||
| line-height: 20px; | ||
| font-weight: 500; | ||
| } | ||
|
|
||
| a.primary { | ||
| background: var(--foreground); | ||
| color: var(--background); | ||
| gap: 8px; | ||
| } | ||
|
|
||
| a.secondary { | ||
| border-color: var(--gray-alpha-200); | ||
| min-width: 180px; | ||
| } | ||
|
|
||
| .footer { | ||
| grid-row-start: 3; | ||
| display: flex; | ||
| gap: 24px; | ||
| } | ||
|
|
||
| .footer a { | ||
| display: flex; | ||
| align-items: center; | ||
| gap: 8px; | ||
| } | ||
|
|
||
| .footer img { | ||
| flex-shrink: 0; | ||
| } | ||
|
|
||
| /* Enable hover only on non-touch devices */ | ||
| @media (hover: hover) and (pointer: fine) { | ||
| a.primary:hover { | ||
| background: var(--button-primary-hover); | ||
| border-color: transparent; | ||
| } | ||
|
|
||
| a.secondary:hover { | ||
| background: var(--button-secondary-hover); | ||
| border-color: transparent; | ||
| } | ||
|
|
||
| .footer a:hover { | ||
| text-decoration: underline; | ||
| text-underline-offset: 4px; | ||
| } | ||
| } | ||
|
|
||
| @media (max-width: 600px) { | ||
| .page { | ||
| padding: 32px; | ||
| padding-bottom: 80px; | ||
| } | ||
|
|
||
| .main { | ||
| align-items: center; | ||
| } | ||
|
|
||
| .main ol { | ||
| text-align: center; | ||
| } | ||
|
|
||
| .ctas { | ||
| flex-direction: column; | ||
| } | ||
|
|
||
| .ctas a { | ||
| font-size: 14px; | ||
| height: 40px; | ||
| padding: 0 16px; | ||
| } | ||
|
|
||
| a.secondary { | ||
| min-width: auto; | ||
| } | ||
|
|
||
| .footer { | ||
| flex-wrap: wrap; | ||
| align-items: center; | ||
| justify-content: center; | ||
| } | ||
| } | ||
|
|
||
| @media (prefers-color-scheme: dark) { | ||
| .logo { | ||
| filter: invert(); | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lms24, @lforst -- Could we create a test project and set these env variables on the CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anecdotally we should avoid depending on any production systems for our tests. We recently stopped doing so in the main js repo because it was blocking us from cutting releases and merging a tad to often. Do you think it would be a hard requirement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems required for testing if the test project builds and runs in the production mode. When there's no valid
AUTH_TOKEN, the build fails as the webpack plugin is already set on thenext.configfile. So, given there's no option to skip configuringnext.configin the wizard at the moment, we can instead do either:next.configfile before building the test project.buildandstart. Only test if the project runs ondevmode which is working without the need for these.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I think we would want to test build and start so I am on board with pointing to a prod project. We should just make sure that it is not blocking 1) Releases of the wizard 2) PRs 3) Local test runs.
We can point the tests to the
sentry-javascript-sdksorg and thesentry-wizard-e2e-testsproject. I think this can simply be via the github action yaml. Do we need any secrets? If so I can ask for them to be added.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, so adding the
AUTH_TOKENwould be enough for now, I'll set the rest on the GA yaml.