feat: allow passing or and project slug parameters #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
obostjancic
changed the title
Lms24
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
LGTM! Thanks for adding this!
Side-note: We could also make adjustments to our endpoint/view to take the potentially passed params into account to reduce the loading time. Right now, this change would still load a lot of unnecessary data. I'll add a note to #357, which - despite its name - is all about reworking the project selection flow.
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of getsentry/sentry#77381
Adds
--organd--projectparameters that narrow down options in project selection step.If there is only one project matching the provided slugs it gets automatically selected.
If no projects match the passed slugs wizard falls back to the current behaviour