Skip to content

fix(remix): Don't create .sentrclirc if project uses Vite. #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2024
Merged

fix(remix): Don't create .sentrclirc if project uses Vite. #667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6d9f5c
fix(remix): Don't create `.sentrclirc` if project uses Vite.
onurtemizkan Sep 9, 2024
698e04c
Add CHANGELOG entry.
onurtemizkan Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- ref(nextjs): Adjust dev server command in verification message (#665)
- feat(remix): Add feature selection (#646)
- fix(remix): Don't create `.sentrclirc` if project uses Vite (#667)

## 3.28.0

Expand Down
4 changes: 2 additions & 2 deletions src/remix/remix-wizard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,6 @@ async function runRemixWizardWithTelemetry(
},
] as const);

await addSentryCliConfig({ authToken }, rcCliSetupConfig);

if (viteConfig) {
await traceStep(
'Update vite configuration for sourcemap uploads',
Expand Down Expand Up @@ -125,6 +123,8 @@ async function runRemixWizardWithTelemetry(
url: sentryUrl === DEFAULT_URL ? undefined : sentryUrl,
isHydrogen: isHydrogenApp(packageJson),
});

await addSentryCliConfig({ authToken }, rcCliSetupConfig);
} catch (e) {
clack.log
.warn(`Could not update build script to generate and upload sourcemaps.
Expand Down
Loading