feat: Try running Prettier on exit #644
Conversation
|
|
Oof I totally missed this PR, Sorry! I'll take a look soon! |
src/run.ts
Outdated
| clack.log.error(`No setup wizard selected!`); | ||
| } | ||
|
|
||
| await runPrettierIfInstalled(); |
There was a problem hiding this comment.
h: let's move this call inside the individual run*wizard functions. If we leave it here, the prompt would be rendered after the outro messages which looks a bit off.
There was a problem hiding this comment.
@Lms24, moved the prettier runs inside nextjs, remix, svelte and react-native wizards.
onurtemizkan
force-pushed
the
onur/run-prettier
branch
from
ba016a8 to
3783251
Compare
There was a problem hiding this comment.
Thanks Onur! Tested with SvelteKit and it worked well. I think there's a limitation we might need to address depending on user feedback which is that we might need to limit applying prettier to the changed files. Should probably be doable since we know which files we generally modify. We could also use git commands to find new/changed files.
I'll merge this in for now but feel free to work on this if you have free cycles.
2 participants
Resolves: #521