-
-
Notifications
You must be signed in to change notification settings - Fork 56
chore: Move startup tracing into the SDK #2234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We didn't have any tests on this prior. :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How much of it was AI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of having Startup Tracing be split between SentryInitialization
and SentryIntegration
we can delete the latter and move everything into internal StartupTracing
inside the SDK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How much of it was AI?
This is in part to help with #2227
We can have startup tracing be its own integration within the SDK instead of shipping it as a
.cs
that compiles with the game.Things to note:
RuntimeInitializeOnLoadMethod
attribute from within the SDK. The only requirement is that those arestatic
methods and take no argumentsIsStartupTracingAllowed
check.StartupAlreadyCaptured
after scene loading.StartupAlreadyCaptured
also handles the case of manual initialization later than during startup since#skip-changelog