-
-
Notifications
You must be signed in to change notification settings - Fork 56
Drop support for Unity 2019 #2231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -7,7 +7,7 @@ on: | |||
type: string | |||
|
|||
env: | |||
LOWEST_SUPPORTED_UNITY_VERSION: 2019 | |||
LOWEST_SUPPORTED_UNITY_VERSION: 2020 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the version used for packaging.
@@ -87,7 +87,7 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
unity-version: ["2019", "2022", "6000"] | |||
unity-version: ["2020", "2022", "6000"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not found a way to get these out of the matrix into the environment.
@@ -61,7 +61,7 @@ jobs: | |||
ssh-key: ${{ secrets.CI_DEPLOY_KEY }} | |||
|
|||
- name: Update sample ProjectVersion.txt | |||
if: ${{ matrix.unity-prefix == '2019' }} | |||
if: ${{ matrix.unity-prefix == '2020' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually irrelevant. Unity 2020 LTS reached its EOL in mid-2023. Specifically, the final patch version was 2020.3.48.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The scene tracing can now go into the SDK itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also update the packages. Previously, were using the sample project for smoke testing in CI. For that we've stripped all non-required packages to keep it as slim as possible. We're building a new smoke test project from scratch now for a while and I'd rather have the sample be the same that all users would have.
CHANGELOG.md
Outdated
@@ -2,6 +2,10 @@ | |||
|
|||
## Unreleased | |||
|
|||
### Breaking Changes | |||
|
|||
- Updated Unity support by updating to Unity versions (2020+), removing Unity 2019 which reached End of Life in 2022 ([#2231](https://github.com/getsentry/sentry-unity/pull/2231)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start with "Dropped support for Unity 2019" since this is the most importantly part of the note
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Drop support for Unity 2019 ([#2231](https://github.com/getsentry/sentry-unity/pull/2231)) If none of the above apply, you can opt out of this check by adding |
Version 2019 reached EOL mid 2022.
Apart from that there are other considerations: