feat: feature flags #1951
Open
feat: feature flags #1951
+210
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Litarnus
approved these changes
Nov 3, 2025
| /** | ||
| * @var array<int, array<string, bool>> The list of flags associated to this scope | ||
| */ | ||
| private $flags = []; |
There was a problem hiding this comment.
It's a bit weird that we used indexed arrays here but assoc arrays for spans. I assume this is to make the LRU cache work?
There was a problem hiding this comment.
Correct, I also could have gone for array{string, bool}, don't think I need a key-value array here but it also probably doesn't really matter what the inner structure is. But I agree it's not an optimal design. If you have a suggestion I'm open to it but I wanted to get the feature built and see if we find it worth the squeeze to optimize this data structure.
There was a problem hiding this comment.
No I think it's fine, it makes sense to have them as they are with the current requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for setting feature flag evaluations on the scope and spans. This is modeled after the Python SDK. Intended purpose is to allow us to integrate with Laravel Pennant.
See: