test(node): Replace express v5 integration tests with E2E test #17147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to duplicate all the express integration tests and run yarn separately for them to test express v5. This is a bit unfortunate and also hard to keep in sync (already we added/changed tests in express v4 but not v5). This PR replaces the express v5 stuff with a dedicated express-v5 e2e test - we actually did not have any of that so far :O
I thought about using v5 by default and having an express-v4 e2e test app instead, but express v4 is still vastly more in use than v5, so that's probably easier.