Skip to content

test(node): Replace express v5 integration tests with E2E test #17147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 24, 2025

Conversation

mydea
Copy link
Member

@mydea mydea commented Jul 24, 2025

We used to duplicate all the express integration tests and run yarn separately for them to test express v5. This is a bit unfortunate and also hard to keep in sync (already we added/changed tests in express v4 but not v5). This PR replaces the express v5 stuff with a dedicated express-v5 e2e test - we actually did not have any of that so far :O

I thought about using v5 by default and having an express-v4 e2e test app instead, but express v4 is still vastly more in use than v5, so that's probably easier.

@mydea mydea requested review from AbhiPrasad and andreiborza July 24, 2025 10:19
@mydea mydea self-assigned this Jul 24, 2025
Copy link
Contributor

github-actions bot commented Jul 24, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.75 kB - -
@sentry/browser - with treeshaking flags 22.33 kB - -
@sentry/browser (incl. Tracing) 39.39 kB - -
@sentry/browser (incl. Tracing, Replay) 77.52 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.36 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 82.22 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 94.34 kB - -
@sentry/browser (incl. Feedback) 40.44 kB - -
@sentry/browser (incl. sendFeedback) 28.42 kB - -
@sentry/browser (incl. FeedbackAsync) 33.33 kB - -
@sentry/react 25.49 kB - -
@sentry/react (incl. Tracing) 41.39 kB - -
@sentry/vue 28.18 kB - -
@sentry/vue (incl. Tracing) 41.21 kB - -
@sentry/svelte 23.77 kB - -
CDN Bundle 25.16 kB - -
CDN Bundle (incl. Tracing) 39.2 kB - -
CDN Bundle (incl. Tracing, Replay) 75.2 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 80.64 kB - -
CDN Bundle - uncompressed 73.42 kB - -
CDN Bundle (incl. Tracing) - uncompressed 116.08 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 230.06 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 242.88 kB - -
@sentry/nextjs (client) 43.41 kB - -
@sentry/sveltekit (client) 39.83 kB - -
@sentry/node-core 47.32 kB - -
@sentry/node 143.92 kB +0.26% +370 B 🔺
@sentry/node - without tracing 91.4 kB - -
@sentry/aws-serverless 102.85 kB - -

View base workflow run

@mydea mydea marked this pull request as ready for review July 24, 2025 11:00
@mydea mydea merged commit 5faef85 into develop Jul 24, 2025
151 of 152 checks passed
@mydea mydea deleted the fn/drop-express-v5-tests branch July 24, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants