feat(react-router): Add support for Hydrogen with RR7 #17145
+1,563
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurtemizkan
changed the title
size-limit report 📦
|
onurtemizkan
force-pushed
the
onur/hydrogen-rr7
branch
2 times, most recently
from
e84f411 to
305c9c2
Compare
onurtemizkan
force-pushed
the
onur/hydrogen-rr7
branch
from
305c9c2 to
a38286d
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| }); | ||
|
|
||
| return stream; | ||
| } |
There was a problem hiding this comment.
Bug: Stream Handling and Data Type Inconsistency
The injectTraceMetaTags function has two bugs. It incorrectly assumes the </head> tag will always be contained within a single ReadableStream chunk. If the tag is split across chunks, the includes check fails, preventing Sentry trace meta tags from being injected and breaking distributed tracing. Additionally, the function outputs inconsistent data types: it encodes modified HTML as Uint8Array but passes through unmodified chunks as their original type (e.g., string), which can cause issues for downstream consumers.
Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hydrogen switched from Remix v2 to React Router 7 (framework mode) from version
2025.5.0.This PR adds support for React Router 7 (framework) SDK, adding a new entry point for cloudflare environments, and making a few structural changes.
@sentry/react-router/cloudflareentrypoint, similarly to what we have done on@sentry/remix/cloudflare.injectTraceMetaTagsto supportReadableStreamwhich is used instead ofPipeableStream(which we cover ongetMetaTagTransformerfor node environments), on cloudflare environments.Note: Needs documentation update if approved.