test(core): Add explicit tests for tracesSampler returning negative sampling decisions
#17055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sampling decisions
Lms24
requested review from
a team,
stephanie-anderson,
msonnb and
s1gr1d
and removed request for
a team and
stephanie-anderson
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
3 tasks
andreiborza
approved these changes
Jul 17, 2025
s1gr1d
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a couple of unit tests to explicitly test sampling behaviour of the core SDK's sampling logic when users pass in a
tracesSamplerfunction returning negative sampling values (i.e.0,false).According to coverage, this is tested implicitly already but I couldn't find specific explicit tests that assert on this expected outcome. Decided to add some while investigating #16849.