Skip to content

feat: Avoid usage of any #17041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

feat: Avoid usage of any #17041

wants to merge 3 commits into from

Conversation

mydea
Copy link
Member

@mydea mydea commented Jul 16, 2025

This makes the lint rule error, instead of warn, and gets rid of some more any usage. Some of that may technically be breaking because the types can be exposed, but this should be very unlikely to affect any users.

In a future version of eslint, this is on by default, but IMHO it makes sense for us anyhow - any should only be used when absolutely necessary and when we make a conscious choice to do so.

@mydea mydea requested review from Lms24 and AbhiPrasad July 16, 2025 13:28
@mydea mydea self-assigned this Jul 16, 2025
@mydea mydea requested review from a team as code owners July 16, 2025 13:28
Copy link
Contributor

github-actions bot commented Jul 16, 2025

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 23.76 kB -0.01% -1 B 🔽
@sentry/browser - with treeshaking flags 22.34 kB -0.02% -3 B 🔽
@sentry/browser (incl. Tracing) 39.41 kB -0.01% -3 B 🔽
@sentry/browser (incl. Tracing, Replay) 77.5 kB -0.03% -17 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.37 kB -0.03% -17 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 82.21 kB -0.03% -18 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 94.35 kB -0.01% -3 B 🔽
@sentry/browser (incl. Feedback) 40.46 kB +0.03% +11 B 🔺
@sentry/browser (incl. sendFeedback) 28.44 kB -0.02% -3 B 🔽
@sentry/browser (incl. FeedbackAsync) 33.34 kB -0.01% -2 B 🔽
@sentry/react 25.5 kB -0.01% -1 B 🔽
@sentry/react (incl. Tracing) 41.38 kB -0.02% -6 B 🔽
@sentry/vue 28.19 kB -0.01% -2 B 🔽
@sentry/vue (incl. Tracing) 41.21 kB -0.01% -4 B 🔽
@sentry/svelte 23.79 kB -0.01% -1 B 🔽
CDN Bundle 25.28 kB +0.01% +1 B 🔺
CDN Bundle (incl. Tracing) 39.28 kB - -
CDN Bundle (incl. Tracing, Replay) 75.38 kB -0.02% -10 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 80.82 kB -0.01% -6 B 🔽
CDN Bundle - uncompressed 73.86 kB +0.01% +4 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 116.3 kB +0.01% +4 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 230.53 kB -0.01% -7 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 243.34 kB -0.01% -7 B 🔽
@sentry/nextjs (client) 43.43 kB -0.02% -7 B 🔽
@sentry/sveltekit (client) 39.84 kB -0.01% -3 B 🔽
@sentry/node-core 47.48 kB +0.01% +1 B 🔺
@sentry/node 144.13 kB +0.01% +9 B 🔺
@sentry/node - without tracing 91.58 kB +0.01% +5 B 🔺
@sentry/aws-serverless 103.04 kB +0.01% +6 B 🔺

View base workflow run

@mydea mydea force-pushed the fn/avoid-any branch 2 times, most recently from ead56db to f0881c5 Compare July 18, 2025 06:39
@mydea mydea enabled auto-merge (squash) July 18, 2025 06:39
mydea added 3 commits July 25, 2025 14:13
This makes the lint rule error, instead of warn, and gets rid of some more any usage.
Some of that may technically be breaking because the types can be exposed, but this should be very unlikely to affect any users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants