Skip to content

ref(feedback): Use debug instead of logger #17027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

ref(feedback): Use debug instead of logger #17027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/feedback/src/core/integration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import type {
Integration,
IntegrationFn,
} from '@sentry/core';
import { addIntegration, isBrowser, logger } from '@sentry/core';
import { addIntegration, debug, isBrowser } from '@sentry/core';
import {
ADD_SCREENSHOT_LABEL,
CANCEL_BUTTON_LABEL,
Expand Down Expand Up @@ -194,7 +194,7 @@ export const buildFeedbackIntegration = ({
addIntegration(modalIntegration);
} catch {
DEBUG_BUILD &&
logger.error(
debug.error(
'[Feedback] Error when trying to load feedback integrations. Try using `feedbackSyncIntegration` in your `Sentry.init`.',
);
throw new Error('[Feedback] Missing feedback modal integration!');
Expand All @@ -213,7 +213,7 @@ export const buildFeedbackIntegration = ({
}
} catch {
DEBUG_BUILD &&
logger.error('[Feedback] Missing feedback screenshot integration. Proceeding without screenshots.');
debug.error('[Feedback] Missing feedback screenshot integration. Proceeding without screenshots.');
}

const dialog = modalIntegration.createDialog({
Expand Down Expand Up @@ -243,7 +243,7 @@ export const buildFeedbackIntegration = ({
typeof el === 'string' ? DOCUMENT.querySelector(el) : typeof el.addEventListener === 'function' ? el : null;

if (!targetEl) {
DEBUG_BUILD && logger.error('[Feedback] Unable to attach to target element');
DEBUG_BUILD && debug.error('[Feedback] Unable to attach to target element');
throw new Error('Unable to attach to target element');
}

Expand Down
4 changes: 2 additions & 2 deletions packages/feedback/src/modal/components/Form.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import type {
FeedbackScreenshotIntegration,
SendFeedback,
} from '@sentry/core';
import { logger } from '@sentry/core';
import { debug } from '@sentry/core';
import type { JSX, VNode } from 'preact';
import { h } from 'preact'; // eslint-disable-line @typescript-eslint/no-unused-vars
import { useCallback, useState } from 'preact/hooks';
Expand Down Expand Up @@ -130,7 +130,7 @@ export function Form({
);
onSubmitSuccess(data, eventId);
} catch (error) {
DEBUG_BUILD && logger.error(error);
DEBUG_BUILD && debug.error(error);
setError(error as string);
onSubmitError(error as Error);
}
Expand Down
Loading