-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
test(nextjs): Run e2e tests for nextjs-15 in turbopack #17018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dev-packages/e2e-tests/test-applications/nextjs-15/tests/prefetch-spans.test.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Inconsistent Build Script Causes Errors
The test:build-turbo
script is inconsistent with other build commands. It directly calls next build --turbopack
instead of pnpm next build
or leveraging the main build
script. This bypasses standard error handling and output redirection, potentially masking build failures and risking the use of a global next
binary. Additionally, unlike other test:build-*
scripts, it does not explicitly specify React versions, which could lead to compatibility issues.
dev-packages/e2e-tests/test-applications/nextjs-15/package.json#L14-L15
sentry-javascript/dev-packages/e2e-tests/test-applications/nextjs-15/package.json
Lines 14 to 15 in 3f9d8cb
"test:build-latest": "pnpm install && pnpm add next@15.0.0-canary.194 && pnpm add react@19.0.0-rc-cd22717c-20241013 && pnpm add react-dom@19.0.0-rc-cd22717c-20241013 && pnpm build", | |
"test:build-turbo": "pnpm install && pnpm add next@15.4.2-canary.1 && next build --turbopack", |
Was this report helpful? Give feedback by reacting with 👍 or 👎
closes https://linear.app/getsentry/issue/FE-546/extend-turbopack-e2e-tests