Skip to content

test(nextjs): Run e2e tests for nextjs-15 in turbopack #17018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 16, 2025

Conversation

chargome
Copy link
Member

@chargome chargome commented Jul 15, 2025

closes https://linear.app/getsentry/issue/FE-546/extend-turbopack-e2e-tests

  • Updates nextjs-turbo test to actually run latest version
  • Updates next-15 test to also run for turbopack (using latest 15.4 canary as we need both turbopack support and ppr support here)

@chargome chargome self-assigned this Jul 15, 2025
Copy link

linear bot commented Jul 15, 2025

@chargome chargome marked this pull request as ready for review July 16, 2025 15:12
cursor[bot]

This comment was marked as outdated.

@chargome chargome requested a review from RulaKhaled July 16, 2025 15:14
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Inconsistent Build Script Causes Errors

The test:build-turbo script is inconsistent with other build commands. It directly calls next build --turbopack instead of pnpm next build or leveraging the main build script. This bypasses standard error handling and output redirection, potentially masking build failures and risking the use of a global next binary. Additionally, unlike other test:build-* scripts, it does not explicitly specify React versions, which could lead to compatibility issues.

dev-packages/e2e-tests/test-applications/nextjs-15/package.json#L14-L15

"test:build-latest": "pnpm install && pnpm add next@15.0.0-canary.194 && pnpm add react@19.0.0-rc-cd22717c-20241013 && pnpm add react-dom@19.0.0-rc-cd22717c-20241013 && pnpm build",
"test:build-turbo": "pnpm install && pnpm add next@15.4.2-canary.1 && next build --turbopack",

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

@chargome chargome merged commit 75439ef into develop Jul 16, 2025
144 checks passed
@chargome chargome deleted the cg-next-more-turbo-tests branch July 16, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants