fix(browser): Guard against undefined nextHopProtocol

[AbhiPrasad]

fixes #16804

Although PerformanceResourceTiming.nextHopProtocol is available in all the browsers we support in v9, I think adding an extra guard is reasonable to make it easier for older browser support (it's hard to polyfill some of the performance apis).

This PR just adds a condition if (resourceTiming.nextHopProtocol != undefined).

Used cursor to generate some tests for the resourceTimingToSpanAttributes I extracted out.

[github-actions]

size-limit report 📦

Path	Size	% Change	Change
@sentry/browser	23.99 kB	-	-
@sentry/browser - with treeshaking flags	23.76 kB	-	-
@sentry/browser (incl. Tracing)	39.59 kB	+0.02%	+7 B 🔺
@sentry/browser (incl. Tracing, Replay)	77.7 kB	+0.02%	+8 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	70.79 kB	+0.02%	+11 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)	82.46 kB	+0.02%	+10 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)	94.58 kB	+0.01%	+9 B 🔺
@sentry/browser (incl. Feedback)	40.75 kB	-	-
@sentry/browser (incl. sendFeedback)	28.7 kB	-	-
@sentry/browser (incl. FeedbackAsync)	33.59 kB	-	-
@sentry/react	25.76 kB	-	-
@sentry/react (incl. Tracing)	41.59 kB	+0.03%	+9 B 🔺
@sentry/vue	28.37 kB	-	-
@sentry/vue (incl. Tracing)	41.41 kB	+0.02%	+7 B 🔺
@sentry/svelte	24.01 kB	-	-
CDN Bundle	25.5 kB	-	-
CDN Bundle (incl. Tracing)	39.61 kB	+0.03%	+10 B 🔺
CDN Bundle (incl. Tracing, Replay)	75.51 kB	+0.02%	+9 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)	80.97 kB	+0.01%	+8 B 🔺
CDN Bundle - uncompressed	74.5 kB	-	-
CDN Bundle (incl. Tracing) - uncompressed	117.66 kB	+0.03%	+34 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed	231.71 kB	+0.02%	+34 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	244.53 kB	+0.02%	+34 B 🔺
@sentry/nextjs (client)	43.23 kB	+0.03%	+12 B 🔺
@sentry/sveltekit (client)	40.05 kB	+0.04%	+13 B 🔺
@sentry/node	162.03 kB	-	-
@sentry/node - without tracing	98.64 kB	-	-
@sentry/aws-serverless	124.4 kB	-	-

View base workflow run

[cursor]

Bug: Protocol Extraction Triggered Incorrectly

The condition if (resourceTiming.nextHopProtocol != undefined) incorrectly calls extractNetworkProtocol when nextHopProtocol is an empty string. This contradicts test expectations that extractNetworkProtocol should not be called for empty or undefined values. The condition should be if (resourceTiming.nextHopProtocol) to properly handle these cases.

packages/browser/src/tracing/resource-timing.ts#L18-L19

sentry-javascript/packages/browser/src/tracing/resource-timing.ts

Lines 18 to 19 in 0c449a4

	const timingSpanData: Array<Parameters<Span['setAttribute']>> = [];
	if (resourceTiming.nextHopProtocol != undefined) {

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎