test: Run E2E tests in isolated tmp directory

.github/workflows/build.yml

@@ -920,19 +920,23 @@ jobs:
         env:
           E2E_TEST_PUBLISH_SCRIPT_NODE_VERSION: ${{ steps.versions.outputs.node }}
 
+      - name: Copy to temp
+        run: yarn ci:copy-to-temp ./test-applications/${{ matrix.test-application }} ${{ runner.temp }}/test-application
+        working-directory: dev-packages/e2e-tests
+
       - name: Build E2E app
-        working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
+        working-directory: ${{ runner.temp }}/test-application
         timeout-minutes: 7
         run: pnpm ${{ matrix.build-command || 'test:build' }}
 
       - name: Install Playwright
         uses: ./.github/actions/install-playwright
         with:
           browsers: chromium
-          cwd: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
+          cwd: ${{ runner.temp }}/test-application
 
       - name: Run E2E test
-        working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
+        working-directory: ${{ runner.temp }}/test-application
         timeout-minutes: 10
         run: pnpm test:assert
 
@@ -941,7 +945,7 @@ jobs:
         if: failure()
         with:
           name: playwright-traces-job_e2e_playwright_tests-${{ matrix.test-application}}
-          path: dev-packages/e2e-tests/test-applications/${{ matrix.test-application}}/test-results
+          path: ${{ runner.temp }}/test-application/test-results
           overwrite: true
           retention-days: 7
 
@@ -955,7 +959,7 @@ jobs:
         if: always()
         with:
           name: E2E Test Dump (${{ matrix.label || matrix.test-application }})
-          path: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}/event-dumps
+          path: ${{ runner.temp }}/test-application/event-dumps
           overwrite: true
           retention-days: 7
           if-no-files-found: ignore
@@ -1037,19 +1041,23 @@ jobs:
         env:
           E2E_TEST_PUBLISH_SCRIPT_NODE_VERSION: ${{ steps.versions.outputs.node }}
 
+      - name: Copy to temp
+        run: yarn ci:copy-to-temp ./test-applications/${{ matrix.test-application }} ${{ runner.temp }}/test-application
+        working-directory: dev-packages/e2e-tests
+
       - name: Build E2E app
-        working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
+        working-directory: ${{ runner.temp }}/test-application
         timeout-minutes: 7
         run: pnpm ${{ matrix.build-command || 'test:build' }}
 
       - name: Install Playwright
         uses: ./.github/actions/install-playwright
         with:
           browsers: chromium
-          cwd: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
+          cwd: ${{ runner.temp }}/test-application
 
       - name: Run E2E test
-        working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
+        working-directory: ${{ runner.temp }}/test-application
         timeout-minutes: 10
         run: pnpm ${{ matrix.assert-command || 'test:assert' }}
 
@@ -1063,20 +1071,19 @@ jobs:
         if: always()
         with:
           name: E2E Test Dump (${{ matrix.label || matrix.test-application }})
-          path: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}/event-dumps
+          path: ${{ runner.temp }}/test-application/event-dumps
           overwrite: true
           retention-days: 7
           if-no-files-found: ignore
 
       - name: Deploy Astro to Cloudflare
-        uses: cloudflare/pages-action@v1
+        uses: cloudflare/wrangler-action@v3
         if: matrix.test-application == 'cloudflare-astro'
         with:
           apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
           accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
-          projectName: ${{ secrets.CLOUDFLARE_PROJECT_NAME }}
-          directory: dist
-          workingDirectory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
+          command: pages deploy dist --project-name=${{ secrets.CLOUDFLARE_PROJECT_NAME }}
+          workingDirectory: ${{ runner.temp }}/test-application
 
   job_required_jobs_passed:
     name: All required jobs passed or were skipped

.github/workflows/canary.yml

@@ -153,19 +153,23 @@ jobs:
         env:
           E2E_TEST_PUBLISH_SCRIPT_NODE_VERSION: ${{ steps.versions.outputs.node }}
 
+      - name: Copy to temp
+        run: yarn ci:copy-to-temp ./test-applications/${{ matrix.test-application }} ${{ runner.temp }}/test-application
+        working-directory: dev-packages/e2e-tests
+
       - name: Build E2E app
-        working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
+        working-directory: ${{ runner.temp }}/test-application
         timeout-minutes: 7
         run: yarn ${{ matrix.build-command }}
 
       - name: Install Playwright
         uses: ./.github/actions/install-playwright
         with:
           browsers: chromium
-          cwd: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
+          cwd: ${{ runner.temp }}/test-application
 
       - name: Run E2E test
-        working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
+        working-directory: ${{ runner.temp }}/test-application
         timeout-minutes: 15
         run: yarn test:assert
 

dev-packages/e2e-tests/ciCopyToTemp.ts

@@ -0,0 +1,19 @@
+/* eslint-disable no-console */
+
+import { copyToTemp } from './lib/copyToTemp';
+
+async function run(): Promise<void> {
+  const originalPath = process.argv[2];
+  const tmpDirPath = process.argv[3];
+
+  if (!originalPath || !tmpDirPath) {
+    throw new Error('Original path and tmp dir path are required');
+  }
+
+  console.log(`Copying ${originalPath} to ${tmpDirPath}...`);
+
+  await copyToTemp(originalPath, tmpDirPath);
+}
+
+// eslint-disable-next-line @typescript-eslint/no-floating-promises
+run();

dev-packages/e2e-tests/lib/copyToTemp.ts

@@ -0,0 +1,61 @@
+/* eslint-disable no-console */
+import { readFileSync, writeFileSync } from 'fs';
+import { cp } from 'fs/promises';
+import { join } from 'path';
+
+export async function copyToTemp(originalPath: string, tmpDirPath: string): Promise<void> {
+  // copy files to tmp dir
+  await cp(originalPath, tmpDirPath, { recursive: true });
+
+  fixPackageJson(tmpDirPath);
+}
+
+function fixPackageJson(cwd: string): void {
+  const packageJsonPath = join(cwd, 'package.json');
+  const packageJson = JSON.parse(readFileSync(packageJsonPath, 'utf8')) as {
+    dependencies?: Record<string, string>;
+    devDependencies?: Record<string, string>;
+    volta?: Record<string, unknown>;
+  };
+
+  // 1. Fix file dependencies
+  if (packageJson.dependencies) {
+    fixFileLinkDependencies(packageJson.dependencies);
+  }
+  if (packageJson.devDependencies) {
+    fixFileLinkDependencies(packageJson.devDependencies);
+  }
+
+  // 2. Fix volta extends
+  if (!packageJson.volta) {
+    throw new Error('No volta config found, please provide one!');
+  }
+
+  if (typeof packageJson.volta.extends === 'string') {
+    const extendsPath = packageJson.volta.extends;
+    // We add a virtual dir to ensure that the relative depth is consistent
+    // dirPath is relative to ./../test-applications/xxx
+    const newPath = join(__dirname, 'virtual-dir/', extendsPath);
+    packageJson.volta.extends = newPath;
+    console.log(`Fixed volta.extends to ${newPath}`);
+  } else {
+    console.log('No volta.extends found');
+  }
+
+  writeFileSync(packageJsonPath, JSON.stringify(packageJson, null, 2));
+}
+
+function fixFileLinkDependencies(dependencyObj: Record<string, string>): void {
+  for (const [key, value] of Object.entries(dependencyObj)) {
+    if (value.startsWith('link:')) {
+      const dirPath = value.replace('link:', '');
+
+      // We add a virtual dir to ensure that the relative depth is consistent
+      // dirPath is relative to ./../test-applications/xxx
+      const newPath = join(__dirname, 'virtual-dir/', dirPath);
+
+      dependencyObj[key] = `link:${newPath}`;
+      console.log(`Fixed ${key} dependency to ${newPath}`);
+    }
+  }
+}

dev-packages/e2e-tests/package.json

@@ -16,7 +16,8 @@
     "clean": "rimraf tmp node_modules && yarn clean:test-applications && yarn clean:pnpm",
     "ci:build-matrix": "ts-node ./lib/getTestMatrix.ts",
     "ci:build-matrix-optional": "ts-node ./lib/getTestMatrix.ts --optional=true",
-    "clean:test-applications": "rimraf --glob test-applications/**/{node_modules,dist,build,.next,.nuxt,.sveltekit,.react-router,.astro,.output,pnpm-lock.yaml,.last-run.json,test-results}",
+    "ci:copy-to-temp": "ts-node ./ciCopyToTemp.ts",
+    "clean:test-applications": "rimraf --glob test-applications/**/{node_modules,dist,build,.next,.nuxt,.sveltekit,.react-router,.astro,.output,pnpm-lock.yaml,.last-run.json,test-results,.angular,event-dumps}",
     "clean:pnpm": "pnpm store prune"
   },
   "devDependencies": {

dev-packages/e2e-tests/run.ts

@@ -1,8 +1,11 @@
 /* eslint-disable no-console */
 import { spawn } from 'child_process';
 import * as dotenv from 'dotenv';
+import { mkdtemp, rm } from 'fs/promises';
 import { sync as globSync } from 'glob';
-import { resolve } from 'path';
+import { tmpdir } from 'os';
+import { join, resolve } from 'path';
+import { copyToTemp } from './lib/copyToTemp';
 import { registrySetup } from './registrySetup';
 
 const DEFAULT_DSN = 'https://username@domain/123';
@@ -39,7 +42,7 @@ async function run(): Promise<void> {
   dotenv.config();
 
   // Allow to run a single app only via `yarn test:run <app-name>`
-  const appName = process.argv[2];
+  const appName = process.argv[2] || '';
 
   const dsn = process.env.E2E_TEST_DSN || DEFAULT_DSN;
 
@@ -74,13 +77,20 @@ async function run(): Promise<void> {
     console.log('');
 
     for (const testAppPath of testAppPaths) {
-      const cwd = resolve('test-applications', testAppPath);
+      const originalPath = resolve('test-applications', testAppPath);
+      const tmpDirPath = await mkdtemp(join(tmpdir(), `sentry-e2e-tests-${appName}-`));
 
-      console.log(`Building ${testAppPath}...`);
+      await copyToTemp(originalPath, tmpDirPath);
+      const cwd = tmpDirPath;
+
+      console.log(`Building ${testAppPath} in ${tmpDirPath}...`);
       await asyncExec('pnpm test:build', { env, cwd });
 
       console.log(`Testing ${testAppPath}...`);
       await asyncExec('pnpm test:assert', { env, cwd });
+
+      // clean up (although this is tmp, still nice to do)
+      await rm(tmpDirPath, { recursive: true });
     }
   } catch (error) {
     console.error(error);

dev-packages/e2e-tests/test-applications/angular-17/package.json

@@ -5,7 +5,7 @@
     "ng": "ng",
     "dev": "ng serve",
     "proxy": "node start-event-proxy.mjs",
-    "preview": "http-server dist/angular-17/browser --port 8080",
+    "preview": "http-server dist/angular-17/browser --port 8080 --silent",
     "build": "ng build",
     "watch": "ng build --watch --configuration development",
     "test": "playwright test",
@@ -31,6 +31,7 @@
   "devDependencies": {
     "@playwright/test": "~1.50.0",
     "@sentry-internal/test-utils": "link:../../../test-utils",
+    "@sentry/core": "latest || *",
     "@angular-devkit/build-angular": "^17.1.1",
     "@angular/cli": "^17.1.1",
     "@angular/compiler-cli": "^17.1.0",

dev-packages/e2e-tests/test-applications/angular-17/tests/performance.test.ts

@@ -1,5 +1,6 @@
 import { expect, test } from '@playwright/test';
 import { waitForTransaction } from '@sentry-internal/test-utils';
+// Cannot use @sentry/angular here due to build stuff
 import { SEMANTIC_ATTRIBUTE_SENTRY_OP, SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN } from '@sentry/core';
 
 test('sends a pageload transaction with a parameterized URL', async ({ page }) => {

dev-packages/e2e-tests/test-applications/angular-18/package.json

@@ -5,7 +5,7 @@
     "ng": "ng",
     "dev": "ng serve",
     "proxy": "node start-event-proxy.mjs",
-    "preview": "http-server dist/angular-18/browser --port 8080",
+    "preview": "http-server dist/angular-18/browser --port 8080 --silent",
     "build": "ng build",
     "watch": "ng build --watch --configuration development",
     "test": "playwright test",
@@ -31,6 +31,7 @@
   "devDependencies": {
     "@playwright/test": "~1.50.0",
     "@sentry-internal/test-utils": "link:../../../test-utils",
+    "@sentry/core": "latest || *",
     "@angular-devkit/build-angular": "^18.0.0",
     "@angular/cli": "^18.0.0",
     "@angular/compiler-cli": "^18.0.0",

dev-packages/e2e-tests/test-applications/angular-18/tests/performance.test.ts

@@ -1,5 +1,6 @@
 import { expect, test } from '@playwright/test';
 import { waitForTransaction } from '@sentry-internal/test-utils';
+// Cannot use @sentry/angular here due to build stuff
 import { SEMANTIC_ATTRIBUTE_SENTRY_OP, SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN } from '@sentry/core';
 
 test('sends a pageload transaction with a parameterized URL', async ({ page }) => {

dev-packages/e2e-tests/test-applications/angular-19/package.json

@@ -5,7 +5,7 @@
     "ng": "ng",
     "dev": "ng serve",
     "proxy": "node start-event-proxy.mjs",
-    "preview": "http-server dist/angular-19/browser --port 8080",
+    "preview": "http-server dist/angular-19/browser --port 8080 --silent",
     "build": "ng build",
     "watch": "ng build --watch --configuration development",
     "test": "playwright test",
@@ -34,6 +34,7 @@
     "@angular/compiler-cli": "^19.0.0",
     "@playwright/test": "~1.50.0",
     "@sentry-internal/test-utils": "link:../../../test-utils",
+    "@sentry/core": "latest || *",
     "@types/jasmine": "~5.1.0",
     "http-server": "^14.1.1",
     "jasmine-core": "~5.4.0",
@@ -43,5 +44,8 @@
     "karma-jasmine": "~5.1.0",
     "karma-jasmine-html-reporter": "~2.1.0",
     "typescript": "~5.6.2"
+  },
+  "volta": {
+    "extends": "../../package.json"
   }
 }

dev-packages/e2e-tests/test-applications/angular-19/start-event-proxy.mjs

@@ -2,5 +2,5 @@ import { startEventProxyServer } from '@sentry-internal/test-utils';
 
 startEventProxyServer({
   port: 3031,
-  proxyServerName: 'angular-18',
+  proxyServerName: 'angular-19',
 });

dev-packages/e2e-tests/test-applications/angular-19/tests/errors.test.ts

@@ -2,7 +2,7 @@ import { expect, test } from '@playwright/test';
 import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';
 
 test('sends an error', async ({ page }) => {
-  const errorPromise = waitForError('angular-18', async errorEvent => {
+  const errorPromise = waitForError('angular-19', async errorEvent => {
     return !errorEvent.type;
   });
 
@@ -30,11 +30,11 @@ test('sends an error', async ({ page }) => {
 });
 
 test('assigns the correct transaction value after a navigation', async ({ page }) => {
-  const pageloadTxnPromise = waitForTransaction('angular-18', async transactionEvent => {
+  const pageloadTxnPromise = waitForTransaction('angular-19', async transactionEvent => {
     return !!transactionEvent?.transaction && transactionEvent.contexts?.trace?.op === 'pageload';
   });
 
-  const errorPromise = waitForError('angular-18', async errorEvent => {
+  const errorPromise = waitForError('angular-19', async errorEvent => {
     return !errorEvent.type;
   });