fix(core): Prevent unhandled promise rejection in withMonitor #16753
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
withMonitor
function was causing unhandled promise rejections when wrapping async callbacks that throw errors. This could crash servers when monitoring async operations.When a promise returned by the callback rejected, the error was being thrown inside the promise rejection handler:
Solution
Simply remove the
throw e;
line. The original promise is already returned to the caller, so they can handle the rejection appropriately.Fixes #JS-620