ref(browser): Ensure fetch transport has tracing suppressed
#16532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Lms24
reviewed
Jun 10, 2025
Comment on lines
+48
to
+49
| return suppressTracing(() => { | ||
| return nativeFetch(options.url, requestOptions).then(response => { |
There was a problem hiding this comment.
wait this seems off. Why would we need to suppress tracing when using nativeFetch? Shouldn't this be instrumentation-free in the first place?
There was a problem hiding this comment.
yeah, this seems to be true, this is not triggering anything anyhow. Maybe we can just remove the comment and call it a day 😅
There was a problem hiding this comment.
yeah I don't see us switching to browser OTel anytime soon 😅
mydea
force-pushed
the
fn/suppress-tracing-browser-fetch
branch
from
0c4ba76 to
8acf5d1
Compare
mydea
force-pushed
the
fn/suppress-tracing-browser-fetch
branch
from
8acf5d1 to
d82d630
Compare
mydea
added a commit
that referenced
this pull request
Jun 17, 2025
Replaces #16532 Updates the comment in the browser fetch transport to explain why we do not need to suppress tracing there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that this was missing, should be fine to do that!