-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[WIP] feat(nextjs): Add URL to tags of server component and layout issues #16499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,125 @@ | ||
import { getSanitizedUrlStringFromUrlObject, parseStringToURLObject } from '@sentry/core'; | ||
|
||
type ComponentRouteParams = Record<string, string> | undefined; | ||
type HeadersDict = Record<string, string> | undefined; | ||
|
||
const HeaderKeys = { | ||
FORWARDED_PROTO: 'x-forwarded-proto', | ||
FORWARDED_HOST: 'x-forwarded-host', | ||
HOST: 'host', | ||
REFERER: 'referer', | ||
} as const; | ||
|
||
/** | ||
* Replaces route parameters in a path template with their values | ||
* @param path - The path template containing parameters in [paramName] format | ||
* @param params - Optional route parameters to replace in the template | ||
* @returns The path with parameters replaced | ||
*/ | ||
function substituteRouteParams(path: string, params?: ComponentRouteParams): string { | ||
if (!params || typeof params !== 'object') return path; | ||
|
||
let resultPath = path; | ||
for (const [key, value] of Object.entries(params)) { | ||
const paramPattern = /\[([^\]]+)\]/g; | ||
resultPath = resultPath.replace(paramPattern, (match, paramName) => { | ||
return paramName === key ? encodeURIComponent(value) : match; | ||
}); | ||
} | ||
return resultPath; | ||
} | ||
|
||
/** | ||
* Normalizes a path by removing route groups and multiple slashes | ||
* @param path - The path to normalize | ||
* @returns The normalized path | ||
*/ | ||
function sanitizeRoutePath(path: string): string { | ||
const normalizedPath = path | ||
.replace(/\([^)]+\)/g, '') // Remove route groups | ||
Comment on lines
+38
to
+39
Check failureCode scanning / CodeQL Polynomial regular expression used on uncontrolled data High
This
regular expression Error loading related location Loading library input Error loading related location Loading This regular expression Error loading related location Loading library input Error loading related location Loading |
||
.replace(/\/{2,}/g, '/') // Normalize multiple slashes | ||
.replace(/\/$/, ''); // Remove trailing slash | ||
|
||
return normalizedPath || '/'; // Ensure root path is '/' | ||
} | ||
|
||
/** | ||
* Constructs a full URL from the component route, parameters, and headers. | ||
* | ||
* @param componentRoute - The route template to construct the URL from | ||
* @param params - Optional route parameters to replace in the template | ||
* @param headersDict - Optional headers containing protocol and host information | ||
* @param pathname - Optional pathname coming from parent span "http.target" | ||
* @returns A sanitized URL string | ||
*/ | ||
export function buildUrlFromComponentRoute( | ||
componentRoute: string, | ||
params?: ComponentRouteParams, | ||
headersDict?: HeadersDict, | ||
pathname?: string, | ||
): string { | ||
const parameterisedPath = substituteRouteParams(componentRoute, params); | ||
// pathname has precedence over the parameterised path if it exists | ||
// spans like generateMetadata and Server Component rendering, are normally direct children of the root http.server span | ||
const path = pathname ?? sanitizeRoutePath(parameterisedPath); | ||
|
||
const protocol = headersDict?.[HeaderKeys.FORWARDED_PROTO]; | ||
const host = headersDict?.[HeaderKeys.FORWARDED_HOST] || headersDict?.[HeaderKeys.HOST]; | ||
|
||
if (!protocol || !host) { | ||
return path; | ||
} | ||
|
||
const fullUrl = `${protocol}://${host}${path}`; | ||
|
||
const urlObject = parseStringToURLObject(fullUrl); | ||
if (!urlObject) { | ||
return path; | ||
} | ||
|
||
return getSanitizedUrlStringFromUrlObject(urlObject); | ||
} | ||
|
||
/** | ||
* Returns a sanitized URL string from the referer header if it exists and is valid. | ||
* | ||
* @param headersDict - Optional headers containing the referer | ||
* @returns A sanitized URL string or undefined if referer is missing/invalid | ||
*/ | ||
export function extractSanitizedUrlFromRefererHeader(headersDict?: HeadersDict): string | undefined { | ||
const referer = headersDict?.[HeaderKeys.REFERER]; | ||
if (!referer) { | ||
return undefined; | ||
} | ||
|
||
try { | ||
const refererUrl = new URL(referer); | ||
return getSanitizedUrlStringFromUrlObject(refererUrl); | ||
} catch (error) { | ||
return undefined; | ||
} | ||
} | ||
|
||
/** | ||
* Returns a sanitized URL string using the referer header if available, | ||
* otherwise constructs the URL from the component route, params, and headers. | ||
* | ||
* @param componentRoute - The route template to construct the URL from | ||
* @param params - Optional route parameters to replace in the template | ||
* @param headersDict - Optional headers containing protocol, host, and referer | ||
* @param pathname - Optional pathname coming from root span "http.target" | ||
* @returns A sanitized URL string | ||
*/ | ||
export function getSanitizedRequestUrl( | ||
componentRoute: string, | ||
params?: ComponentRouteParams, | ||
headersDict?: HeadersDict, | ||
pathname?: string, | ||
): string { | ||
const refererUrl = extractSanitizedUrlFromRefererHeader(headersDict); | ||
if (refererUrl) { | ||
return refererUrl; | ||
} | ||
|
||
return buildUrlFromComponentRoute(componentRoute, params, headersDict, pathname); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High