fix(react-native): Enhance fragment detection for indirect references #767
+837
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
Jul 21, 2025
| Program: { | ||
| enter(path, state) { | ||
| const fragmentContext = collectFragmentContext(path); | ||
| state['sentryFragmentContext'] = fragmentContext; |
There was a problem hiding this comment.
We should update AnnotationPluginPass to strongly type sentryFragmentContext.
AbhiPrasad
reviewed
Jul 21, 2025
| @@ -151,7 +166,8 @@ function functionBodyPushAttributes( | |||
| componentName: string, | |||
| sourceFileName: string | undefined, | |||
| attributeNames: string[], | |||
| ignoredComponents: string[] | |||
| ignoredComponents: string[], | |||
| fragmentContext?: FragmentContext | |||
There was a problem hiding this comment.
Might be time to convert this to take an object instead of plain args (and also add a jsdoc to document)
Lms24
reviewed
Jul 21, 2025
There was a problem hiding this comment.
Sounds reasonable to me -- thanks for adding all the tests!
Besides Abhi's feedback, could you take a look at the integration test? Perhaps we can add a fragment or two there as well (but happy to leave this up to you. If it's too much of a hassle that's fine as well)
|
Thank you both for the reviews and feedback. I really appreciate this 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes getsentry/sentry-react-native#4902