test: More bundler versions #725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timfish
force-pushed
the
timfish/test/more-bundler-versions
branch
2 times, most recently
from
fb6d441 to
d6f1854
Compare
timfish
force-pushed
the
timfish/test/more-bundler-versions
branch
from
d6f1854 to
6736847
Compare
timfish
commented
Apr 10, 2025
| @@ -6,10 +6,10 @@ import { testIfNodeMajorVersionIsLessThan18 } from "../../utils/testIf"; | |||
|
|
|||
| function checkBundle(bundlePath1: string, bundlePath2: string) { | |||
| const process1Output = childProcess.execSync(`node ${bundlePath1}`, { encoding: "utf-8" }); | |||
| expect(process1Output).toBe("undefined\n"); | |||
There was a problem hiding this comment.
Looks like newer versions of Node have more/different control characters at the end of the output because these were failing on v20 and v22!
Lms24
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: