Skip to content

Revert "feat(core)!: Use globalThis for code injection" #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

lforst
Copy link

@lforst lforst commented Jan 15, 2025

Reverts #610

See #610 (comment) as to why.

@lforst lforst requested review from timfish and andreiborza January 15, 2025 08:25
@timfish
Copy link
Collaborator

timfish commented Jan 15, 2025

Do you need to revert the changlog?

@lforst
Copy link
Author

lforst commented Jan 15, 2025

@timfish I am on the changelog!

@lforst lforst merged commit 07a98c8 into main Jan 15, 2025
18 checks passed
@lforst lforst deleted the revert-610-use-globalThis branch January 15, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants